Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup @babel/plugin-transform-destructuring configuration #8215

Conversation

henryqdineen
Copy link
Contributor

@henryqdineen henryqdineen commented Dec 20, 2019

The @babel/plugin-transform-destructuring Babel plugin does not have a selectiveLoose option currently and this code has been a source of confusion for me and possibly others. It was introduced in #5997 and I'm not sure if the intention was to wait for the selectiveLoose option to be available. Even if this worked as hoped for I think that only useState and useReducer should be targeted for this optimization.

Thanks! Please let me know if I'm missing something obvious.

@henryqdineen henryqdineen changed the title remove usage of non-existent selectiveLoose cleanup @babel/plugin-transform-destructuring configuration Dec 20, 2019
@sumanbh
Copy link

sumanbh commented Dec 23, 2019

I think selectiveLoose option relies on this PR on babel which hasn't been merged yet.

@henryqdineen
Copy link
Contributor Author

Yep. I noticed that PR and don't see any activity on it.

@stale
Copy link

stale bot commented Jan 22, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@henryqdineen
Copy link
Contributor Author

I noticed it was marked as stale. I still think this is a valid PR.

@stale stale bot removed the stale label Jan 23, 2020
@ianschmitz
Copy link
Contributor

ianschmitz commented Jan 23, 2020

If we decided to get rid of the customization, we can remove the plugin entirely as it's provided by preset-env.

@ianschmitz ianschmitz added this to the 3.x milestone Jan 30, 2020
@ianschmitz
Copy link
Contributor

Thanks for bringing this to our attention! I took a slightly different approach in #8353, and removed it entirely.

I included you as a co-author so you get credit as well 👍

@ianschmitz ianschmitz closed this Jan 30, 2020
@henryqdineen
Copy link
Contributor Author

thanks @ianschmitz!

@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants