wip: review comments

facebook · Feb 23, 2024 · 220a50f · 220a50f
1 parent 8d7bb9c
commit 220a50f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/packages/docusaurus-plugin-content-blog/src/__tests__/index.test.ts b/packages/docusaurus-plugin-content-blog/src/__tests__/index.test.ts
@@ -213,7 +213,6 @@ describe('blog plugin', () => {
           name: 'Yangshun Tay (translated)',
         },
         {
-          imageURL: undefined,
           email: 'lorber.sebastien@gmail.com',
           key: 'slorber',
           name: 'Sébastien Lorber (translated)',

diff --git a/packages/docusaurus-theme-classic/src/theme/LastUpdated/index.tsx b/packages/docusaurus-theme-classic/src/theme/LastUpdated/index.tsx
@@ -16,7 +16,7 @@ function LastUpdatedAtDate({
 }: {
   lastUpdatedAt: number;
 }): JSX.Element {
-  const convertedLastUpdateAt = lastUpdatedAt * 1000;
+  const atDate = new Date(lastUpdatedAt * 1000);
 
   const dateTimeFormat = useDateTimeFormat({
     day: 'numeric',
@@ -25,11 +25,7 @@ function LastUpdatedAtDate({
     timeZone: 'UTC',
   });
 
-  const formatLastUpdatedAt = (lastUpdated: number) =>
-    dateTimeFormat.format(new Date(lastUpdated));
-
-  const formattedLastUpdatedAt =
-    lastUpdatedAt && formatLastUpdatedAt(convertedLastUpdateAt);
+  const formattedLastUpdatedAt = dateTimeFormat.format(atDate);
 
   return (
     <Translate
@@ -38,7 +34,7 @@ function LastUpdatedAtDate({
       values={{
         date: (
           <b>
-            <time dateTime={new Date(convertedLastUpdateAt).toISOString()}>
+            <time dateTime={atDate.toISOString()}>
               {formattedLastUpdatedAt}
             </time>
           </b>