Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): fix website manifest.json name "Docusaurus v2" to just "Docusaurus" #10049

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

volcanofr
Copy link
Contributor

Updated the "name" field to v3 instead of v2

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Docusaurus is not in v2 anymore.

Test Plan

N/A

Related issues/PRs

N/A

Updated the "name" field to v3 instead of v2
@facebook-github-bot
Copy link
Contributor

Hi @volcanofr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@volcanofr
Copy link
Contributor Author

Also currently the colors are shades of blue.

@volcanofr volcanofr changed the title manifest.json to "v3" Website manifest.json to "v3" Apr 16, 2024
Copy link

netlify bot commented Apr 16, 2024

[V2]

Name Link
🔨 Latest commit 2d7d0e9
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/662136179222510008b742e9
😎 Deploy Preview https://deploy-preview-10049--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 16, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 65 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 68 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 63 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 16, 2024
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Apr 18, 2024
@slorber slorber changed the title Website manifest.json to "v3" fix(website): fix website manifest.json name "Docusaurus v2" to just "Docusaurus" Apr 18, 2024
@slorber slorber merged commit 491af1f into facebook:main Apr 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants