-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme-common): restore useContextualSearchFilters public API for retrocompatibility #10397
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: +407 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
const {i18n} = useDocusaurusContext(); | ||
const docsTags = | ||
// eslint-disable-next-line @typescript-eslint/no-var-requires | ||
require('@docusaurus/plugin-content-docs/client').useDocsContextualSearchTags(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this line to be the one causing me troubles on the official build of fast-check's documentation. This require makes theme-common
pull things from @docusaurus/plugin-content-docs
, which is just a peer.
The issue I'm facing appeared on 3.5.0. I need to come up with a repro implying a simplified version of my setup: yarn berry with docs being on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the issue I'm facing is probably that the very same 3.5.0 moved @docusaurus/plugin-content-docs
from dependency to peer 🤔
Motivation
Restore theme-common API that we consider public.
This reverts an inadvertent breaking change I did while refactoring (#10316)
This breaking change breaks a local search plugin: cmfcmf/docusaurus-search-local#217
This will be released as v3.5.2
Test Plan
local
Test links
https://deploy-preview-10397--docusaurus-2.netlify.app/