fix(argos): waiting for images decoding

[axel7083]

Pre-flight checklist

• I have read the Contributing Guidelines on pull requests.
• If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
• If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

Fix #9805

[facebook-github-bot]

Hi @axel7083!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[netlify]

✅ [V2]

Name	Link
🔨 Latest commit	03b4f60
🔍 Latest deploy log	https://app.netlify.com/sites/docusaurus-2/deploys/65d745309ad89e000860c45d
😎 Deploy Preview	https://deploy-preview-9875--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	PWA	Report
/	🟠 72	🟢 98	🟢 96	🟢 100	🟠 88	Report
/docs/installation	🟠 89	🟢 96	🟢 100	🟢 100	🟠 88	Report
/docs/category/getting-started	🟠 75	🟢 100	🟢 100	🟢 90	🟠 88	Report
/blog	🟠 71	🟢 100	🟢 100	🟢 90	🟠 88	Report
/blog/preparing-your-site-for-docusaurus-v3	🟠 64	🟢 96	🟢 100	🟢 100	🟠 88	Report
/blog/tags/release	🟠 70	🟢 100	🟢 100	🟠 80	🟠 88	Report
/blog/tags	🟠 76	🟢 100	🟢 100	🟢 90	🟠 88	Report

[slorber]

Thanks

@gregberge wouldn't you want this to be included automatically in your Argos Playwright integration package?

https://github.com/argos-ci/argos-javascript/tree/main/packages/playwright

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	🧿 Changes detected (Review)	140 changes	Feb 22, 2024, 1:44 PM

[slorber]

@axel7083 we'll probably add this on the Argos playwright integration, but in its current form, your code doesn't seem to fix the flakiness issue.

[axel7083]

@axel7083 we'll probably add this on the Argos playwright integration, but in its current form, your code doesn't seem to fix the flakiness issue.

Yeah I thought it would, but apparently not - that's a bit annoying actually

[slorber]

looks like the Argos update makes screenshots appear

there are other changes, probably related to the playwright upgrade but that seems ok

[slorber]

Seems to be working, Argos only reports the expected visual diff in this PR now: #9868