Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ES2024 Object.groupBy #1453

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robik
Copy link
Contributor

@robik robik commented Jun 28, 2024

Summary

This PR implements ES2024 Object.groupBy function.

Test Plan

Added tests

$ echo "Object.groupBy([1, 2, 3, 4, 5, 6, 7], key => key)" | ./hermes
>> { 1: [ 1, [length]: 1 ], 2: [ 2, [length]: 1 ], 3: [ 3, [length]: 1 ], 4: [ 4, [length]: 1 ], 5: [ 5, [length]: 1 ], 6: [ 6, [length]: 1 ], 7: [ 7, [length]: 1 ] }

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants