Pass the pointer of owning object in GCHermesValueBase::set() #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D61675022
Differential Revision: D61676721
Differential Revision: D61747499
Differential Revision: D61807366
Differential Revision: D61747510
Differential Revision: D62158417
Differential Revision: D62171114
Summary: Add this parameter so that it could be passed to write barrier function in following diffs. For not it's unused. We don't create a overload or make a default parameter value because it's error prone: new code may call wrong functions (unless reasoning whether the object lives in normal segment or large segment), or forget to update existing calls. It's actually easier to just always pass in the owning object pointer, which in most cases is obvious to get. Differential Revision: D62196480
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add this parameter so that it could be passed to write barrier function
in following diffs. For not it's unused.
We don't create a overload or make a default parameter value because
it's error prone: new code may call wrong functions (unless reasoning
whether the object lives in normal segment or large segment), or forget
to update existing calls. It's actually easier to just always pass in
the owning object pointer, which in most cases is obvious to get.
Differential Revision: D62196480