RFC: -t for remote codemods
#94
Comments
|
👍 I was wondering how you imagined this to work until I saw your PR ;) Yeah, one drawback is that scripts need to be self contained. I'm not really fond of the current practice either. Being able to load codemods remotely is definitely a good idea. We could expand that and make it easier to load them from GitHub or gists. If someone wants to share a more complex codemod with dependencies, they could just put it on npm. |
|
The Browserify web service (https://wzrd.in/) could likely be used ad-hoc for the first constraint (h/t @RReverser) Ensuring the transform is written in valid node code and not babel is the second constraint (e.g React-router codemods use es6 modules) |
jscodeshift passes transforms through Babel by default. But I guess that won't work with the browserify web service then. |
|
What areas would you like me to explore and verify before moving forward with #95? |
|
I'm fine with it as it is (if the test passes). We can always extend this when there is demand. |
|
A test broke when remerging with master. Hope to get that fixed today. |
|
Found the reason. #95 was changed from |
|
NICE! |
|
Who wants to add friendly URLs and the ability to request just the transform to astexplorer? 😀 |
|
astexplorer support is going to be more tricky, since the data has to be loaded from Parse somehow. But Parse is shutting down and we don't know yet where to move it to. If we would run a VPS, we can have the server expose an API to load astexplorer transform data. |
|
@fkling I just thought about that once again - why don't we move to Gists instead as some popular JS playgrounds do? That way, user could load, save and share actual gists across the playgrounds and we wouldn't need to care about the storage at all. |
|
@RReverser: I'd like that, I just haven't used gists programmatically yet. |
|
@fkling My only concern is that all the old URLs will still break. Not sure how to deal with them in that case. |
* Add description of `pure-component` transform * Basic destructuring works Needs to be tested Only works if there are no references to `this.props` by itself Would be nice if it would work for (replace) in-render destructuring * Remove duplicate variable declarations If `bar` is assigned to `this.props.bar` we need to remove that, as it's available as a destrctured arg * Test various scenarios * Update readme with destructure option * Undo accidental indentation change * Made propNames be a set to make sure they are unique * Type Arrays to Array * Rename option to `destructuring` * Simplify build argument * Identify shadowing and do not destructure * Retain type annotations * Change option name in readme destructure -> destructuring
Currently, community-specific codemods are appearing inside specific repos without much shareability and the ergonomics to apply them require quite a bit of manual effort (especially for a tool based around removing manual effort).
Allowing
-tto accept remote codemods would enable a generic way to build a hosted service and share codemods.The text was updated successfully, but these errors were encountered: