Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the case where there's only 1 CPU #137

Merged
merged 2 commits into from
Jul 29, 2016

Conversation

daedalus28
Copy link
Contributor

Should fix #136

@ghost
Copy link

ghost commented Jul 29, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@daedalus28
Copy link
Contributor Author

Just signed the CLA

@ghost ghost added the CLA Signed label Jul 29, 2016
@Daniel15
Copy link
Member

Daniel15 commented Jul 29, 2016

Looks good, thanks! 👍

What about Math.max(require('os').cpus().length - 1, 1)? I think it captures the intent better.

@daedalus28
Copy link
Contributor Author

Works for me, just made the change. Pretty excited to get this merged 👍

@ghost
Copy link

ghost commented Jul 29, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fkling
Copy link
Contributor

fkling commented Jul 29, 2016

That was quick, thank you! I will look at the other PRs today and will try to get a new version out today.

Thank you again!

@fkling fkling merged commit 1b16340 into facebook:master Jul 29, 2016
@daedalus28
Copy link
Contributor Author

Awesome, glad to have this fixed 😄

@daedalus28 daedalus28 deleted the patch-1 branch July 29, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spawning 0 Workers - jscodeshift doesn't run in an environment with 1 CPU
3 participants