Add '--silent' or '-s' option to suppress output #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
signed |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks a lot! |
fkling
added a commit
that referenced
this pull request
Dec 19, 2015
Add '--silent' or '-s' option to suppress output
|
No problem =). Happy to help ^^. |
euphocat
pushed a commit
to euphocat/jscodeshift
that referenced
this pull request
Oct 22, 2017
) JSX uses capitalization to determine what type of `React.createElement` call to produce: if the name starts with a lower-case letter, `React.createElement` is called with the name as a string. Otherwise, it is called with the name as an identifier. This means that an expression like `React.createElement(componentClass)` cannot be converted to JSX, since `<componentClass />` would transform to the string form. This commit changes the script to detect and skip these cases so that the script does not introduce correctness issues.
euphocat
pushed a commit
to euphocat/jscodeshift
that referenced
this pull request
Oct 22, 2017
In facebook#79, I made it so the transformation is skipped in some cases, in particular when the capitalization is invalid. This broke an assumption elsewhere in the code that `convertNodeToJSX` always returns a `JSXElement`, so there was a crash if a skipped element was used as a child. To fix, we can just wrap in a `JSXExpressionContainer` for that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue ref: #60