RU needsUpdate -> shouldUpdate

Summary: per comments on D61265667 Differential Revision: D61383856 fbshipit-source-id: 78c10c601f06973b21992b801bfd54698d7086d7
facebook · Aug 16, 2024 · 668efcc · 668efcc
1 parent 1836c13
commit 668efcc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/litho-rendercore/src/main/java/com/facebook/rendercore/MountState.kt b/litho-rendercore/src/main/java/com/facebook/rendercore/MountState.kt
@@ -845,7 +845,7 @@ constructor(
     currentMountItem.update(renderTreeNode)
     currentRenderUnit.onStartUpdateRenderUnit()
     mountDelegate?.startNotifyVisibleBoundsChangedSection()
-    if (currentRenderUnit.needsUpdate(renderUnit) ||
+    if (currentRenderUnit.shouldUpdate(renderUnit) ||
         !isEqualOrEquivalentTo(currentLayoutData, newLayoutData)) {
       val traceIdentifier =
           DebugEventDispatcher.generateTraceIdentifier(DebugEvent.RenderUnitUpdated)

diff --git a/litho-rendercore/src/main/java/com/facebook/rendercore/RenderUnit.kt b/litho-rendercore/src/main/java/com/facebook/rendercore/RenderUnit.kt
@@ -653,7 +653,7 @@ constructor(
     }
   }
 
-  open fun needsUpdate(newRenderUnit: RenderUnit<MOUNT_CONTENT>): Boolean = this !== newRenderUnit
+  open fun shouldUpdate(newRenderUnit: RenderUnit<MOUNT_CONTENT>): Boolean = this !== newRenderUnit
 
   open fun <T : Binder<*, *, *>?> findAttachBinderByClass(klass: Class<T>): T? {
     return attachBinderTypeToDelegateMap?.get(klass)?.binder as T?