Skip to content

Commit

Permalink
Enable K2 compiler for majority of BizApp’s targets.
Browse files Browse the repository at this point in the history
Summary:
Enabling K2 compiler on BizApp targets because K2 is faster which reduces build speed time.

I used the paste P1200423876 as a list of all BizApp’s targets. That paste was genereated by the script in this D55318859.

Once I had the lift of targets I used ran `arc bulldozer ‘set k2 True’ ` to make all the changes. After all the buck targets were modified, I tried building BizApp and I removed manually all the target that were causing issues until the build passed.

run_all_fbandroid_tests
run_all_fbandroid_tests_at_diff_time

Reviewed By: RuslanLa

Differential Revision: D55385180

fbshipit-source-id: 6b7727f0adf9daac45b3c33a003e59c438079d7d
  • Loading branch information
Vincent Rodier authored and facebook-github-bot committed Apr 13, 2024
1 parent 2d938d8 commit e38d03b
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ litho_android_library(
]),
autoglob = False,
feature = FBApp_UIFrameworks_Litho_Litho,
k2 = True,
labels = [],
provided_deps = [
LITHO_ANDROIDSUPPORT_TARGET,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ litho_android_library(
abi_generation_mode = "source_only",
autoglob = False,
feature = FBApp_UIFrameworks_Litho_Litho,
k2 = True,
labels = [],
provided_deps = [
LITHO_ANDROIDSUPPORT_TARGET,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ fb_android_library(
]),
autoglob = False,
feature = FBApp_UIFrameworks_Litho_Litho,
k2 = True,
labels = [],
pure_kotlin = False,
visibility = [
Expand Down
1 change: 1 addition & 0 deletions litho-live-data/src/main/kotlin/com/facebook/litho/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ litho_android_library(
srcs = glob(["**/*.kt"]),
abi_generation_mode = "source_only",
autoglob = False,
k2 = True,
labels = [],
visibility = [
"PUBLIC",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ litho_android_library(
]),
autoglob = False,
feature = FBApp_UIFrameworks_Litho_Litho,
k2 = True,
labels = [],
pure_kotlin = False,
required_for_source_only_abi = True,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ load(
litho_android_library(
name = "sections",
feature = FBApp_UIFrameworks_Litho_Litho,
k2 = True,
labels = [],
pure_kotlin = False,
required_for_source_only_abi = True,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ load(
litho_android_library(
name = "canvas",
feature = FBApp_UIFrameworks_Litho_Litho,
k2 = True,
labels = [],
visibility = ["PUBLIC"],
deps = [
Expand Down

0 comments on commit e38d03b

Please sign in to comment.