Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guidance on repo build scripts #3809

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

huntie
Copy link
Member

@huntie huntie commented Aug 1, 2023

Removes mandatory run of yarn build/watch when developing Node.js packages — matching the updated build setup in facebook/react-native#38718 (these packages are now set up to run from source during development).

Partially reverts #3788 "[docs] Add guidance on repo build scripts"

Removes mandatory run of `yarn build/watch` when developing Node.js packages — matching the updated build setup in facebook/react-native#38718 (these packages are now set up to run from source during development).

Partially reverts facebook#3788 "[docs] Add guidance on repo build scripts"
@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 97dfebb
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/64c8de1e09162b0008357c39
😎 Deploy Preview https://deploy-preview-3809--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@huntie huntie marked this pull request as ready for review August 6, 2023 12:35
@huntie huntie merged commit 8d60421 into facebook:main Aug 6, 2023
1 check passed
@huntie huntie deleted the contributing-build-cmd-update branch August 6, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants