Skip to content

Commit

Permalink
Fix proguard template for ReactProp and ReactPropGroup
Browse files Browse the repository at this point in the history 
Summary:
ReactProp and ReactPropGroup were moved in the annotations package but the proguard file was not updated accordingly. This caused apps to crash when built in release using proguard.

Fixes #5655
Closes #5717

Reviewed By: svcscm

Differential Revision: D2905573

Pulled By: lexs

fb-gh-sync-id: 29ab14bacda7254d9896ff3991bf17d7fdfd6ea9
  • Loading branch information
@janicduplessis
janicduplessis authored and facebook-github-bot-9 committed Feb 5, 2016
1 parent 736e900 commit 10c0758
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions local-cli/generator-android/templates/src/app/proguard-rules.pro
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
-keep class * extends com.facebook.react.bridge.NativeModule { *; }
-keepclassmembers,includedescriptorclasses class * { native <methods>; }
-keepclassmembers class * { @com.facebook.react.uimanager.UIProp <fields>; }
-keepclassmembers class * { @com.facebook.react.uimanager.ReactProp <methods>; }
-keepclassmembers class * { @com.facebook.react.uimanager.ReactPropGroup <methods>; }
-keepclassmembers class * { @com.facebook.react.uimanager.annotations.ReactProp <methods>; }
-keepclassmembers class * { @com.facebook.react.uimanager.annotations.ReactPropGroup <methods>; }

-dontwarn com.facebook.react.**

Expand Down

1 comment on commit 10c0758

@mkonicek
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks a lot @janicduplessis.

Please sign in to comment.