Skip to content

Commit

Permalink
Do not crash on onJSBundleLoadedFromServer when fast-refreshing on br…
Browse files Browse the repository at this point in the history
…idgeless mode

Summary:
RN-Tester is currently instacrashing on fast-refresh (pressing r on Metro) as it ends up on `onJSBundleLoadedFromServer`
which throws an exception on Bridgeless mode. I'm fixing it by following the same logic as `onReloadWithJSDebugger`.

Changelog:
[Android] [Fixed] - Do not crash on onJSBundleLoadedFromServer when fast-refreshing on bridgeless mode

Reviewed By: huntie

Differential Revision: D54121838

fbshipit-source-id: 82d98ec0c5b2295f5751525368c956574dd7f3a0
  • Loading branch information
cortinico authored and facebook-github-bot committed Feb 23, 2024
1 parent 2647dc8 commit 44e5bc9
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public void onReloadWithJSDebugger(JavaJSExecutor.Factory proxyExecutorFactory)

@Override
public void onJSBundleLoadedFromServer() {
throw new IllegalStateException("Not implemented for bridgeless mode");
// Not implemented
}

@Override
Expand Down

0 comments on commit 44e5bc9

Please sign in to comment.