Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sanitize measure function results (#44557)
Summary: Pull Request resolved: #44557 We've started seeing assertion failures in Yoga where a `NaN` value makes its way to an `availableHeight` constraint when measuring Litho tree. Because it's only happening on Litho, I have some suspicion this might be originating from a Litho-specific measure function. This adds sanitization in Yoga to measure function results, where we will log an error, and set size to zero, if either dimension ends up being negative of `NaN`. This doesn't really help track down where the error was happening, but Yoga doesn't have great context to show this to begin with. If we see this is issue, next steps would be Litho internal intrumentation to find culprit. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D57285584 fbshipit-source-id: 935fcdd28c05bbac0d73e1c7654ae11a74898537
- Loading branch information