Skip to content

Commit

Permalink
Make React-jsiinspector depends on hermes-engine to fix Dynamic Frame…
Browse files Browse the repository at this point in the history
…works (#43081)

Summary:
Pull Request resolved: #43081

When Hermes i used, it is hermes that provides JSI to React Native and not React-jsi.
This is required to fix the ODR violatons.
Dynamic frameworks requires that all the dependencies are declared explicitly, and missing the `hermes-engine` dependency was breaking the dependency graph.

## Changelog
[Internal] - Make JSIInspector depends o hermes-engine

Reviewed By: motiz88

Differential Revision: D53901016

fbshipit-source-id: a511719647e6203d082696fd572593fd851a1dde
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Feb 18, 2024
1 parent 8ff05b5 commit 475a156
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,8 @@ Pod::Spec.new do |s|
s.dependency "DoubleConversion"
s.dependency "React-runtimeexecutor", version
s.dependency "React-jsi"
if ENV["USE_HERMES"] == nil || ENV["USE_HERMES"] == "1"
s.dependency "hermes-engine"
end

end

0 comments on commit 475a156

Please sign in to comment.