Skip to content

Commit

Permalink
Make prettier ignore generated folders (#39076)
Browse files Browse the repository at this point in the history
Summary:
This change introduce the `.prettierignore` file to skip some generated folders.
Prettier was checking that the JS files inside the Pods/ and the sdks/ folders were properly formatted.
However, we don't control those folders.

Running prettier in those folders was taking extra 10s to 30s on average, some time we can now save.

## Changelog:

[Internal] - Make prettier skip generated folders

Pull Request resolved: #39076

Test Plan:
Tested locally

| Before | After |
| --- | --- |
| <img width="593" alt="Screenshot 2023-08-18 at 11 28 51" src="https://github.com/facebook/react-native/assets/11162307/65eb773b-1966-49cd-bd51-6310fe48cf3b"> | <img width="515" alt="Screenshot 2023-08-18 at 11 29 09" src="https://github.com/facebook/react-native/assets/11162307/969ff9e4-f05b-43bf-9a95-7b37dea7d3d0"> |

Reviewed By: christophpurrer

Differential Revision: D48466583

Pulled By: cipolleschi

fbshipit-source-id: 60a4335af2c337c6d3d143d8d5b56d4a41073feb
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Aug 18, 2023
1 parent ffc9ff0 commit 4deb29a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Ignore Pods
**/Pods

# Ignore hermes as it is downloaded from the react_native_pods
**/sdks/hermes
**/sdks/downloads

0 comments on commit 4deb29a

Please sign in to comment.