-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid emitting mountitems for default values
Summary: Noticed that we emit a large amount of (admittedly cheap) mountitems as part of node creation for values that are all zero (e.g. padding, overflowinset), which we can assume to be already initialised with these values on the native side. There's a further opportunity to do this for State as well, as ReactImageComponentState exports just empty maps to Java. Changelog: [Internal] Reviewed By: genkikondo Differential Revision: D36345402 fbshipit-source-id: 8d776ca124bdb9e1cd4de57a04e2785a9a0f918c
- Loading branch information
1 parent
8a8c33a
commit 56e9aa3
Showing
2 changed files
with
14 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters