-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Hermes: Add tests for hermes-utils.js
Summary: Add test coverage for the new `scripts/hermes/hermes-utils.js` consolidated Hermes scripts. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D36334652 fbshipit-source-id: e9570d1232c21e36da4e6be8c67d80f4ec224326
- Loading branch information
1 parent
494b73c
commit 5dae593
Showing
4 changed files
with
265 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,242 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @format | ||
| */ | ||
|
|
||
| import * as path from 'path'; | ||
|
|
||
| const { | ||
| copyBuildScripts, | ||
| downloadHermesTarball, | ||
| expandHermesTarball, | ||
| getHermesTagSHA, | ||
| readHermesTag, | ||
| setHermesTag, | ||
| } = require('../hermes/hermes-utils'); | ||
|
|
||
| const hermesTag = | ||
| 'hermes-2022-04-28-RNv0.69.0-15d07c2edd29a4ea0b8f15ab0588a0c1adb1200f'; | ||
| const tarballContents = 'dummy string'; | ||
| const hermesTagSha = '5244f819b2f3949ca94a3a1bf75d54a8ed59d94a'; | ||
|
|
||
| const ROOT_DIR = path.normalize(path.join(__dirname, '..', '..')); | ||
| const SDKS_DIR = path.join(ROOT_DIR, 'sdks'); | ||
|
|
||
| let execCalls; | ||
| let fs; | ||
| let shelljs; | ||
|
|
||
| jest.mock('shelljs', () => ({ | ||
| echo: jest.fn(), | ||
| exec: jest.fn(command => { | ||
| if (command.startsWith('curl')) { | ||
| fs.writeFileSync( | ||
| path.join(SDKS_DIR, 'download', `hermes-${hermesTagSha}.tgz`), | ||
| tarballContents, | ||
| ); | ||
| execCalls.curl = true; | ||
| return {code: 0}; | ||
| } | ||
|
|
||
| if (command.startsWith('git')) { | ||
| execCalls.git = true; | ||
| return hermesTagSha + '\n'; | ||
| } | ||
|
|
||
| if (command.startsWith('tar')) { | ||
| fs.mkdirSync(path.join(SDKS_DIR, 'hermes', 'utils'), { | ||
| recursive: true, | ||
| }); | ||
| fs.writeFileSync(path.join(SDKS_DIR, 'hermes', `package.json`), '{}'); | ||
| execCalls.tar = true; | ||
| return {code: 0}; | ||
| } | ||
| }), | ||
| exit: jest.fn(), | ||
| })); | ||
|
|
||
| function populateMockFilesystem() { | ||
| fs.mkdirSync(path.join(SDKS_DIR, 'hermes-engine', 'utils'), { | ||
| recursive: true, | ||
| }); | ||
| fs.writeFileSync( | ||
| path.join( | ||
| ROOT_DIR, | ||
| 'sdks', | ||
| 'hermes-engine', | ||
| 'utils', | ||
| 'build-apple-framework.sh', | ||
| ), | ||
| 'Dummy file', | ||
| ); | ||
| fs.writeFileSync( | ||
| path.join( | ||
| ROOT_DIR, | ||
| 'sdks', | ||
| 'hermes-engine', | ||
| 'utils', | ||
| 'build-ios-framework.sh', | ||
| ), | ||
| 'Dummy file', | ||
| ); | ||
| fs.writeFileSync( | ||
| path.join( | ||
| ROOT_DIR, | ||
| 'sdks', | ||
| 'hermes-engine', | ||
| 'utils', | ||
| 'build-mac-framework.sh', | ||
| ), | ||
| 'Dummy file', | ||
| ); | ||
| fs.writeFileSync( | ||
| path.join(SDKS_DIR, 'hermes-engine', 'hermes-engine.podspec'), | ||
| 'Dummy file', | ||
| ); | ||
| } | ||
|
|
||
| describe('hermes-utils', () => { | ||
| beforeEach(() => { | ||
| jest.resetModules(); | ||
|
|
||
| jest.mock('fs', () => new (require('metro-memory-fs'))()); | ||
| fs = require('fs'); | ||
| fs.reset(); | ||
|
|
||
| populateMockFilesystem(); | ||
|
|
||
| execCalls = Object.create(null); | ||
| shelljs = require('shelljs'); | ||
| }); | ||
| describe('readHermesTag', () => { | ||
| it('should return main if .hermesversion does not exist', () => { | ||
| expect(readHermesTag()).toEqual('main'); | ||
| }); | ||
| it('should return tag from .hermesversion if file exists', () => { | ||
| fs.writeFileSync(path.join(SDKS_DIR, '.hermesversion'), hermesTag); | ||
| expect(readHermesTag()).toEqual(hermesTag); | ||
| }); | ||
| }); | ||
| describe('setHermesTag', () => { | ||
| it('should write tag to .hermesversion file', () => { | ||
| setHermesTag(hermesTag); | ||
| expect( | ||
| fs.readFileSync(path.join(SDKS_DIR, '.hermesversion'), { | ||
| encoding: 'utf8', | ||
| flag: 'r', | ||
| }), | ||
| ).toEqual(hermesTag); | ||
| }); | ||
| it('should set Hermes tag and read it back', () => { | ||
| setHermesTag(hermesTag); | ||
| expect(readHermesTag()).toEqual(hermesTag); | ||
| }); | ||
| }); | ||
| describe('getHermesTagSHA', () => { | ||
| it('should return trimmed commit SHA for Hermes tag', () => { | ||
| expect(getHermesTagSHA(hermesTag)).toEqual(hermesTagSha); | ||
| expect(execCalls.git).toBeTruthy(); | ||
| }); | ||
| }); | ||
| describe('downloadHermesTarball', () => { | ||
| it('should download Hermes tarball to download dir', () => { | ||
| downloadHermesTarball(); | ||
| expect(execCalls.curl).toBeTruthy(); | ||
| expect( | ||
| fs.readFileSync( | ||
| path.join(SDKS_DIR, 'download', `hermes-${hermesTagSha}.tgz`), | ||
| { | ||
| encoding: 'utf8', | ||
| flag: 'r', | ||
| }, | ||
| ), | ||
| ).toEqual(tarballContents); | ||
| }); | ||
| it('should not re-download Hermes tarball if tarball exists', () => { | ||
| fs.mkdirSync(path.join(SDKS_DIR, 'download'), {recursive: true}); | ||
| fs.writeFileSync( | ||
| path.join(SDKS_DIR, 'download', `hermes-${hermesTagSha}.tgz`), | ||
| tarballContents, | ||
| ); | ||
|
|
||
| downloadHermesTarball(); | ||
| expect(execCalls.curl).toBeUndefined(); | ||
| }); | ||
| }); | ||
| describe('expandHermesTarball', () => { | ||
| it('should expand Hermes tarball to Hermes source dir', () => { | ||
| fs.mkdirSync(path.join(SDKS_DIR, 'download'), {recursive: true}); | ||
| fs.writeFileSync( | ||
| path.join(SDKS_DIR, 'download', `hermes-${hermesTagSha}.tgz`), | ||
| tarballContents, | ||
| ); | ||
| expect(fs.existsSync(path.join(SDKS_DIR, 'hermes'))).toBeFalsy(); | ||
| expandHermesTarball(); | ||
| expect(execCalls.tar).toBe(true); | ||
| expect(fs.existsSync(path.join(SDKS_DIR, 'hermes'))).toBeTruthy(); | ||
| }); | ||
| it('should fail if Hermes tarball does not exist', () => { | ||
| expandHermesTarball(); | ||
| expect(execCalls.tar).toBeUndefined(); | ||
| expect(shelljs.exit.mock.calls.length).toBeGreaterThan(0); | ||
| }); | ||
| }); | ||
| describe('copyBuildScripts', () => { | ||
| it('should copy React Native Hermes build scripts to Hermes source directory', () => { | ||
| fs.mkdirSync(path.join(SDKS_DIR, 'hermes', 'utils'), { | ||
| recursive: true, | ||
| }); | ||
| copyBuildScripts(); | ||
| expect( | ||
| fs.readFileSync( | ||
| path.join( | ||
| ROOT_DIR, | ||
| 'sdks', | ||
| 'hermes', | ||
| 'utils', | ||
| 'build-mac-framework.sh', | ||
| ), | ||
| { | ||
| encoding: 'utf8', | ||
| flag: 'r', | ||
| }, | ||
| ), | ||
| ).toEqual( | ||
| fs.readFileSync( | ||
| path.join( | ||
| ROOT_DIR, | ||
| 'sdks', | ||
| 'hermes-engine', | ||
| 'utils', | ||
| 'build-mac-framework.sh', | ||
| ), | ||
| { | ||
| encoding: 'utf8', | ||
| flag: 'r', | ||
| }, | ||
| ), | ||
| ); | ||
| expect( | ||
| fs.readFileSync( | ||
| path.join(SDKS_DIR, 'hermes', 'hermes-engine.podspec'), | ||
| { | ||
| encoding: 'utf8', | ||
| flag: 'r', | ||
| }, | ||
| ), | ||
| ).toEqual( | ||
| fs.readFileSync( | ||
| path.join(SDKS_DIR, 'hermes-engine', 'hermes-engine.podspec'), | ||
| { | ||
| encoding: 'utf8', | ||
| flag: 'r', | ||
| }, | ||
| ), | ||
| ); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters