Fabric: ShadowTreeDelegate::shadowTreeDidCommit was renamed to `sha…

…dowTreeDidFinishTransaction` Summary: Simple renaming. Now the name is aligned with `SchedulerDelegate::schedulerDidFinishTransaction` and actually expresses the idea that not only commit finished but also a transaction was prepared and layout events were sent. Changelog: [Internal] Fabric-specific internal change. Reviewed By: mdvacca Differential Revision: D18542503 fbshipit-source-id: 54d429ed139383621fe926fa48a4de062f724176
facebook · Nov 16, 2019 · 806a2b8 · 806a2b8
1 parent 3426f1f
commit 806a2b8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/ReactCommon/fabric/mounting/ShadowTree.cpp b/ReactCommon/fabric/mounting/ShadowTree.cpp
@@ -198,7 +198,7 @@ bool ShadowTree::tryCommit(ShadowTreeCommitTransaction transaction) const {
       ShadowTreeRevision{newRootShadowNode, revisionNumber, telemetry});
 
   if (delegate_) {
-    delegate_->shadowTreeDidCommit(*this, mountingCoordinator_);
+    delegate_->shadowTreeDidFinishTransaction(*this, mountingCoordinator_);
   }
 
   return true;

diff --git a/ReactCommon/fabric/mounting/ShadowTreeDelegate.h b/ReactCommon/fabric/mounting/ShadowTreeDelegate.h
@@ -22,7 +22,7 @@ class ShadowTreeDelegate {
   /*
    * Called right after Shadow Tree commit a new state of the the tree.
    */
-  virtual void shadowTreeDidCommit(
+  virtual void shadowTreeDidFinishTransaction(
       ShadowTree const &shadowTree,
       MountingCoordinator::Shared const &mountingCoordinator) const = 0;
 

diff --git a/ReactCommon/fabric/uimanager/UIManager.cpp b/ReactCommon/fabric/uimanager/UIManager.cpp
@@ -298,10 +298,10 @@ ShadowTreeRegistry const &UIManager::getShadowTreeRegistry() const {
 
 #pragma mark - ShadowTreeDelegate
 
-void UIManager::shadowTreeDidCommit(
+void UIManager::shadowTreeDidFinishTransaction(
     ShadowTree const &shadowTree,
     MountingCoordinator::Shared const &mountingCoordinator) const {
-  SystraceSection s("UIManager::shadowTreeDidCommit");
+  SystraceSection s("UIManager::shadowTreeDidFinishTransaction");
 
   if (delegate_) {
     delegate_->uiManagerDidFinishTransaction(mountingCoordinator);

diff --git a/ReactCommon/fabric/uimanager/UIManager.h b/ReactCommon/fabric/uimanager/UIManager.h
@@ -50,7 +50,7 @@ class UIManager final : public ShadowTreeDelegate {
 
 #pragma mark - ShadowTreeDelegate
 
-  void shadowTreeDidCommit(
+  void shadowTreeDidFinishTransaction(
       ShadowTree const &shadowTree,
       MountingCoordinator::Shared const &mountingCoordinator) const override;