Deprecate RCTImageLoader category of RCTBridge [2/N]

Summary: We no longer want to access RCTImageLoader from the bridge. Reviewed By: shergin Differential Revision: D16389383 fbshipit-source-id: 8e006bf0e2e2651f3ac036c09e589213ac9d29f9
facebook · Jul 24, 2019 · 8a80d61 · 8a80d61
1 parent e9af572
commit 8a80d61
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/Libraries/Image/RCTImageLoader.h b/Libraries/Image/RCTImageLoader.h
@@ -155,11 +155,12 @@ typedef dispatch_block_t RCTImageLoaderCancellationBlock;
 
 @end
 
-@interface RCTBridge (RCTImageLoader)
-
 /**
- * The shared image loader instance
+ * DEPRECATED!! DO NOT USE
+ * Instead use `[_bridge moduleForClass:[RCTImageLoader class]]`
  */
+@interface RCTBridge (RCTImageLoader)
+
 @property (nonatomic, readonly) RCTImageLoader *imageLoader;
 
 @end

diff --git a/Libraries/Image/RCTImageLoader.m b/Libraries/Image/RCTImageLoader.m
@@ -936,10 +936,16 @@ - (void)cancelRequest:(id)requestToken
 
 @end
 
+/**
+ * DEPRECATED!! DO NOT USE
+ * Instead use `[_bridge moduleForClass:[RCTImageLoader class]]`
+ */
 @implementation RCTBridge (RCTImageLoader)
 
 - (RCTImageLoader *)imageLoader
 {
+  RCTLogWarn(@"Calling bridge.imageLoader is deprecated and will not work in newer versions of RN. Please update to the"
+             "moduleForClass API or turboModuleLookupDelegate API.");
   return [self moduleForClass:[RCTImageLoader class]];
 }