Skip to content

Commit

Permalink
Update profiler button to use "Toggle" string. (#41900)
Browse files Browse the repository at this point in the history
Summary:
Fixes #38192, this issue wasn't fixed properly, cortinico fixed same case but for inspector button.

## Changelog:

[ANDROID] [FIXED] - Update profiler button to use "Toggle" string.

Pull Request resolved: #41900

Test Plan: CI

Reviewed By: cortinico

Differential Revision: D52049181

Pulled By: ryancat

fbshipit-source-id: 9225edb3a5a582b879f4ebb835f6ac52cba4c042
  • Loading branch information
szymonrybczak authored and facebook-github-bot committed Dec 12, 2023
1 parent da3ba74 commit 8bcaed9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import com.facebook.debug.holder.PrinterHolder;
import com.facebook.debug.tags.ReactDebugOverlayTags;
import com.facebook.infer.annotation.Assertions;
import com.facebook.react.R;
import com.facebook.react.bridge.CatalystInstance;
import com.facebook.react.bridge.JSBundleLoader;
import com.facebook.react.bridge.JavaJSExecutor;
Expand Down Expand Up @@ -100,7 +101,7 @@ public BridgeDevSupportManager(
}

addCustomDevOption(
mIsSamplingProfilerEnabled ? "Disable Sampling Profiler" : "Enable Sampling Profiler",
applicationContext.getString(R.string.catalyst_sample_profiler_toggle),
new DevOptionHandler() {
@Override
public void onOptionSelected() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
<string name="catalyst_copy_button" project="catalyst" translatable="false">Copy\n</string>
<string name="catalyst_report_button" project="catalyst" translatable="false">Report</string>
<string name="catalyst_loading_from_url" project="catalyst" translatable="false">Loading from %1$s…</string>
<string name="catalyst_sample_profiler_disable" project="catalyst" translatable="false">Disable Sampling Profiler</string>
<string name="catalyst_sample_profiler_enable" project="catalyst" translatable="false">Enable Sampling Profiler</string>
<string name="catalyst_sample_profiler_toggle" project="catalyst" translatable="false">Toggle Sampling Profiler</string>
<string name="catalyst_dev_menu_header" project="catalyst" translatable="false">React Native Dev Menu (%1$s)</string>
<string name="catalyst_dev_menu_sub_header" project="catalyst" translatable="false">Running %1$s</string>
</resources>

0 comments on commit 8bcaed9

Please sign in to comment.