Skip to content

Commit

Permalink
Upgrade react-native-github Android to support API level 19+
Browse files Browse the repository at this point in the history
Summary:
This diff upgrades react-native-github Android to support API level 19+

changelog: [Android][Deprecated] Deprecate support of Android API levels 16 to 18. The new minSDK version will be 19+ moving forward

Reviewed By: JoshuaGross

Differential Revision: D22734208

fbshipit-source-id: b052721c8cfb44f8d74cf4bbb5b7a769e544d1d9
  • Loading branch information
mdvacca authored and facebook-github-bot committed Jul 31, 2020
1 parent d48f7ba commit 9731986
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion RNTester/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ android {

defaultConfig {
applicationId "com.facebook.react.uiapp"
minSdkVersion 18
minSdkVersion 19
targetSdkVersion 29
versionCode 1
versionName "1.0"
Expand Down
6 changes: 3 additions & 3 deletions ReactAndroid/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ task prepareJSC {
def jscPackagePath = findNodeModulePath(projectDir, "jsc-android")
if (!jscPackagePath) {
throw new GradleScriptException("Could not find the jsc-android npm package", null)
}
}

def jscDist = file("$jscPackagePath/dist")
if (!jscDist.exists()) {
Expand Down Expand Up @@ -223,7 +223,7 @@ task downloadNdkBuildDependencies {
def findNodeModulePath(baseDir, packageName) {
def basePath = baseDir.toPath().normalize()
// Node's module resolution algorithm searches up to the root directory,
// after which the base path will be null
// after which the base path will be null
while (basePath) {
def candidatePath = Paths.get(basePath.toString(), "node_modules", packageName)
if (candidatePath.toFile().exists()) {
Expand Down Expand Up @@ -382,7 +382,7 @@ android {
}

defaultConfig {
minSdkVersion(16)
minSdkVersion(19)
targetSdkVersion(28)
versionCode(1)
versionName("1.0")
Expand Down

0 comments on commit 9731986

Please sign in to comment.