Ship large text measure cache in Fabric Android

Summary: Ship large text measure cache in Fabric Android changelog: [internal] internal Reviewed By: sammy-SC Differential Revision: D34602873 fbshipit-source-id: bd0a77b8b2f85301a78d528e7810938b78c7f7b8
facebook · Mar 3, 2022 · 97f3eb2 · 97f3eb2
1 parent 8669277
commit 97f3eb2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java
@@ -100,4 +100,10 @@ public static boolean doesUseOverflowInset() {
   public static boolean insertZReorderBarriersOnViewGroupChildren = true;
 
   public static boolean enableDelayedViewStateDeletion = false;
+
+  /**
+   * Feature Flag to control the size of the cache used by TextLayoutManager in Fabric. Used from
+   * JNI.
+   */
+  public static boolean enableLargeTextMeasureCache = true;
 }
diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp
@@ -76,6 +76,14 @@ Binding::getInspectorDataForInstance(
   return ReadableNativeMap::newObjectCxxArgs(result);
 }
 
+bool isLargeTextMeasureCacheEnabled() {
+  static const auto reactFeatureFlagsJavaDescriptor =
+      jni::findClassStatic(Binding::ReactFeatureFlagsJavaDescriptor);
+  const auto field = reactFeatureFlagsJavaDescriptor->getStaticField<jboolean>(
+      "enableLargeTextMeasureCache");
+  return reactFeatureFlagsJavaDescriptor->getStaticFieldValue(field);
+}
+
 bool isMapBufferSerializationEnabled() {
   static const auto reactFeatureFlagsJavaDescriptor =
       jni::findClassStatic(Binding::ReactFeatureFlagsJavaDescriptor);
@@ -437,9 +445,7 @@ void Binding::installFabricUIManager(
       "react_native_new_architecture:dispatch_preallocation_in_bg");
 
   contextContainer->insert(
-      "EnableLargeTextMeasureCache",
-      reactNativeConfig_->getBool(
-          "react_fabric:enable_large_text_measure_cache_android"));
+      "EnableLargeTextMeasureCache", isLargeTextMeasureCacheEnabled());
 
   auto toolbox = SchedulerToolbox{};
   toolbox.contextContainer = contextContainer;