Skip to content

Commit

Permalink
Fix build break in MSVC (#26462)
Browse files Browse the repository at this point in the history
Summary:
Merging react-native-windows to 0.60 - the visual studio compiler seems to take issue with the existing code

## Changelog

[Internal] [Fixed] - Build fix for react-native-windows (MSVC)
Pull Request resolved: #26462

Test Plan:
No real change, just making compilers happy.

### Side Note
We'll want this change cherry-pickered to RN 0.60 and RN 0.61 so users of react-native-windows dont have to use our fork of react-native.

Reviewed By: mhorowitz

Differential Revision: D17406081

Pulled By: TheSavior

fbshipit-source-id: bc056e1a545c6478fdcbd5645f3a8dea657162c8
  • Loading branch information
acoates-ms authored and facebook-github-bot committed Sep 17, 2019
1 parent 487ff2a commit 9833ee7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ReactCommon/jsi/jsi/jsi.h
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ class PropNameID : public Pointer {
using Pointer::Pointer;

PropNameID(Runtime& runtime, const PropNameID& other)
: PropNameID(runtime.clonePropNameID(other.ptr_)) {}
: Pointer(runtime.clonePropNameID(other.ptr_)) {}

PropNameID(PropNameID&& other) = default;
PropNameID& operator=(PropNameID&& other) = default;
Expand Down

0 comments on commit 9833ee7

Please sign in to comment.