Skip to content

Commit

Permalink
fix: make sure we can build hermes when working against stable
Browse files Browse the repository at this point in the history
  • Loading branch information
Riccardo Cipolleschi committed Jul 19, 2022
1 parent a19578d commit c120db2
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
15 changes: 12 additions & 3 deletions scripts/hermes/hermes-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,19 @@ function isOnAReleaseTag() {

function shouldBuildHermesFromSource() {
const hermesTag = readHermesTag();

const onReleaseBranch = isOnAReleaseBranch();
const onReleaseTag = isOnAReleaseTag();
const hermesTagIsDefault = hermesTag === DEFAULT_HERMES_TAG;

// Logging for CI Debugging
console.log(`[Hermes] On release branch? ${onReleaseBranch ? "Yes" : "No"}`)
console.log(`[Hermes] On release tag? ${onReleaseTag ? "Yes" : "No"}`)
console.log(`[Hermes] Hermes Tag is Default? ${hermesTagIsDefault ? "Yes" : "No"}`)
return (
isOnAReleaseBranch() ||
isOnAReleaseTag() ||
hermesTag === DEFAULT_HERMES_TAG
onReleaseBranch ||
onReleaseTag ||
hermesTagIsDefault
);
}

Expand Down
1 change: 1 addition & 0 deletions scripts/hermes/prepare-hermes-for-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const {

async function main() {
if (!shouldBuildHermesFromSource()) {
console.log('[Hermes] Not building from Source')
copyPodSpec();
return;
}
Expand Down

0 comments on commit c120db2

Please sign in to comment.