Skip to content

Commit

Permalink
fix: foreground ripple crash on api < 23 (#37901)
Browse files Browse the repository at this point in the history
Summary:
The Pressable component supports the `foreground` option for ripple. However, using it on old android api levels (e.g. android 5) crashes with

```
Error while updating property
nativeForegroundAndroid' of a view managed by:
RCTView
null
No virtual method setForeground(Landroid/ graphics/drawable/Drawable;)V in class Lcom/ facebook/react/views/view/ReactViewGroup; or its super classes
```

TouchableNativeFeedback.js has a check to make sure this does not happen [as seen here](https://github.com/facebook/react-native/blob/b0485bed0945061becace5af924fa60b17ab295f/packages/react-native/Libraries/Components/Touchable/TouchableNativeFeedback.js#L158)

I also want to point out that this PR can be closed #30466 as it's already implemented

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID] [FIXED] - foreground ripple crashed on api < 23

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests

Pull Request resolved: #37901

Test Plan: tested locally on [another project](react-navigation/react-navigation#11386) because I wasn't able to get RN tester running

Reviewed By: rshest

Differential Revision: D46747310

Pulled By: NickGerleman

fbshipit-source-id: 4ee9062f821f5d629a1a0151c2fef61d836d09a4
  • Loading branch information
vonovak authored and facebook-github-bot committed Jun 15, 2023
1 parent 2ae163a commit ca65d97
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export default function useAndroidRippleForView(

return {
viewProps:
foreground === true
foreground === true && Platform.Version >= 23
? {nativeForegroundAndroid: nativeRippleValue}
: {nativeBackgroundAndroid: nativeRippleValue},
onPressIn(event: PressEvent): void {
Expand Down

0 comments on commit ca65d97

Please sign in to comment.