Enable modernize-avoid-bind in clang tidy

Summary:
changelog: [internal]

I will be enabling more clang tidy rules in Fabric to make it easier for new contributors and standardise the codebase. \
You can read more about the rule in https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-bind.html

Reviewed By: ShikaSD

Differential Revision: D33162192

fbshipit-source-id: b4bb332f3134c42c49559a8baf10aeb7a7fdd87f

ReactCommon/react/renderer/.clang-tidy

@@ -1,5 +1,7 @@
 ---
+InheritParentConfig: true
 Checks: '>
 clang-diagnostic-*,
+modernize-avoid-bind,
 '
 ...

ReactCommon/react/renderer/core/EventBeat.cpp

@@ -32,8 +32,8 @@ void EventBeat::induce() const {
   // Default implementation does nothing.
 }
 
-void EventBeat::setBeatCallback(const BeatCallback &beatCallback) {
-  beatCallback_ = beatCallback;
+void EventBeat::setBeatCallback(BeatCallback beatCallback) {
+  beatCallback_ = std::move(beatCallback);
 }
 
 } // namespace react

ReactCommon/react/renderer/core/EventBeat.h

@@ -73,7 +73,7 @@ class EventBeat {
    * Sets the beat callback function.
    * The callback is must be called on the proper thread.
    */
-  void setBeatCallback(const BeatCallback &beatCallback);
+  void setBeatCallback(BeatCallback beatCallback);
 
  protected:
   /*

ReactCommon/react/renderer/core/EventQueue.cpp

@@ -19,7 +19,7 @@ EventQueue::EventQueue(
     : eventProcessor_(std::move(eventProcessor)),
       eventBeat_(std::move(eventBeat)) {
   eventBeat_->setBeatCallback(
-      std::bind(&EventQueue::onBeat, this, std::placeholders::_1));
+      [this](jsi::Runtime &runtime) { onBeat(runtime); });
 }
 
 void EventQueue::enqueueEvent(RawEvent &&rawEvent) const {