Skip to content

Commit

Permalink
Delete bridge.loadAndExecuteSplitBundleURL
Browse files Browse the repository at this point in the history
Summary:
Changelog:
[iOS][Removed] - Delete bridge.loadAndExecuteSplitBundleURL

Reviewed By: cortinico

Differential Revision: D46166549

fbshipit-source-id: a0854e4abcdd11542629f5f6bbce89c45e30e9cd
  • Loading branch information
RSNara authored and facebook-github-bot committed May 31, 2023
1 parent 70f3a26 commit e2d512a
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 50 deletions.
7 changes: 0 additions & 7 deletions packages/react-native/React/Base/RCTBridge.h
Original file line number Diff line number Diff line change
Expand Up @@ -227,11 +227,4 @@ RCT_EXTERN void RCTSetTurboModuleCleanupMode(RCTTurboModuleCleanupMode mode);
*/
- (BOOL)isBatchActive;

/**
* Loads and executes additional bundles in the VM for development.
*/
- (void)loadAndExecuteSplitBundleURL:(NSURL *)bundleURL
onError:(RCTLoadAndExecuteErrorBlock)onError
onComplete:(dispatch_block_t)onComplete;

@end
7 changes: 0 additions & 7 deletions packages/react-native/React/Base/RCTBridge.m
Original file line number Diff line number Diff line change
Expand Up @@ -420,11 +420,4 @@ - (void)registerSegmentWithId:(NSUInteger)segmentId path:(NSString *)path
[self.batchedBridge registerSegmentWithId:segmentId path:path];
}

- (void)loadAndExecuteSplitBundleURL:(NSURL *)bundleURL
onError:(RCTLoadAndExecuteErrorBlock)onError
onComplete:(dispatch_block_t)onComplete
{
[self.batchedBridge loadAndExecuteSplitBundleURL:bundleURL onError:onError onComplete:onComplete];
}

@end
36 changes: 0 additions & 36 deletions packages/react-native/React/CxxBridge/RCTCxxBridge.mm
Original file line number Diff line number Diff line change
Expand Up @@ -1089,42 +1089,6 @@ - (void)executeSourceCode:(NSData *)sourceCode withSourceURL:(NSURL *)url sync:(
[self.devSettings setupHMRClientWithBundleURL:self.bundleURL];
}

#if RCT_DEV_MENU | RCT_PACKAGER_LOADING_FUNCTIONALITY
- (void)loadAndExecuteSplitBundleURL:(NSURL *)bundleURL
onError:(RCTLoadAndExecuteErrorBlock)onError
onComplete:(dispatch_block_t)onComplete
{
__weak __typeof(self) weakSelf = self;
[RCTJavaScriptLoader loadBundleAtURL:bundleURL
onProgress:^(RCTLoadingProgress *progressData) {
#if (RCT_DEV_MENU | RCT_DEV_MENU) && __has_include(<React/RCTDevLoadingViewProtocol.h>)
id<RCTDevLoadingViewProtocol> loadingView = [weakSelf moduleForName:@"DevLoadingView"
lazilyLoadIfNecessary:YES];
[loadingView updateProgress:progressData];
#endif
}
onComplete:^(NSError *error, RCTSource *source) {
if (error) {
onError(error);
return;
}

[self enqueueApplicationScript:source.data
url:source.url
onComplete:^{
[self.devSettings setupHMRClientWithAdditionalBundleURL:source.url];
onComplete();
}];
}];
}
#else
- (void)loadAndExecuteSplitBundleURL:(NSURL *)bundleURL
onError:(RCTLoadAndExecuteErrorBlock)onError
onComplete:(dispatch_block_t)onComplete
{
}
#endif

- (void)handleError:(NSError *)error
{
// This is generally called when the infrastructure throws an
Expand Down

0 comments on commit e2d512a

Please sign in to comment.