Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Crash when tap on performance monitor #24820

Closed
zhigang1992 opened this issue May 12, 2019 · 1 comment
Closed

[iOS] Crash when tap on performance monitor #24820

zhigang1992 opened this issue May 12, 2019 · 1 comment
Labels
Bug Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot. Resolution: PR Submitted A pull request with a fix has been provided.

Comments

@zhigang1992
Copy link
Contributor

zhigang1992 commented May 12, 2019 •
edited
Loading

Screen Shot 2019-05-12 at 4 32 13 PM

React Native version:

info 
  React Native Environment Info:
    System:
      OS: macOS 10.14.4
      CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
      Memory: 2.06 GB / 16.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 10.15.1 - /var/folders/0b/k3zlcx0s3936lr99z43_6pxw0000gn/T/fnm-shell-9885663/bin/node
      Yarn: 1.15.2 - /usr/local/bin/yarn
      npm: 6.4.1 - /var/folders/0b/k3zlcx0s3936lr99z43_6pxw0000gn/T/fnm-shell-9885663/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
      Android SDK:
        API Levels: 27, 28
        Build Tools: 27.0.3, 28.0.2, 28.0.3
        System Images: android-28 | Google APIs Intel x86 Atom
    IDEs:
      Android Studio: 3.4 AI-183.5429.30.34.5452501
      Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3 
      react-native: 0.59.8 => 0.59.8

Steps To Reproduce

  1. Launch react native app on iOS simulator
  2. Command + D to activate the performance monitor
  3. Tap on the performance monitor

It should not crash.

Screen Shot 2019-05-12 at 3 48 33 PM
@react-native-bot react-native-bot added the Platform: iOS iOS applications. label May 12, 2019
@zhigang1992 zhigang1992 mentioned this issue May 12, 2019
Closed
@matt-oakes matt-oakes added the Resolution: PR Submitted A pull request with a fix has been provided. label May 13, 2019
facebook-github-bot pushed a commit that referenced this issue May 18, 2019
@zhigang1992 @facebook-github-bot
- fix crash on performance logger (#24821)
5d3d398 
Summary:
Fix Issue #24820

It's caused by `_labelsForTags` and `RCTPLTag` being out of sync, the crash might only be one of the issues that this bug was causing.

## Changelog

[iOS] [Fixed] - fix crash on performance logger
Pull Request resolved: #24821

Differential Revision: D15407291

Pulled By: PeteTheHeat

fbshipit-source-id: c8d2a047fceb9cec981c48fe5181d1b4cbf0976c
@zhongwuzw
Copy link
Contributor

Fixed in #24821.

M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this issue Mar 10, 2020
@zhigang1992 @M-i-k-e-l
- fix crash on performance logger (facebook#24821)
c3e4167 
Summary:
Fix Issue facebook#24820

It's caused by `_labelsForTags` and `RCTPLTag` being out of sync, the crash might only be one of the issues that this bug was causing.

## Changelog

[iOS] [Fixed] - fix crash on performance logger
Pull Request resolved: facebook#24821

Differential Revision: D15407291

Pulled By: PeteTheHeat

fbshipit-source-id: c8d2a047fceb9cec981c48fe5181d1b4cbf0976c
@facebook facebook locked as resolved and limited conversation to collaborators May 28, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot. Resolution: PR Submitted A pull request with a fix has been provided.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matt-oakes @zhigang1992 @zhongwuzw @react-native-bot