Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaultProps from Picker #31603

Closed
lunaleaps opened this issue May 26, 2021 · 4 comments
Closed

Remove defaultProps from Picker #31603

lunaleaps opened this issue May 26, 2021 · 4 comments
Assignees
@kerm1it
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Resolution: Locked This issue was locked by the bot.

Comments

@lunaleaps
Copy link
Contributor

See parent issue: #31602

Expected Results

defaultProps is removed from Picker
@lunaleaps lunaleaps added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Component: Picker labels May 26, 2021
@lunaleaps lunaleaps mentioned this issue May 26, 2021
Closed
6 tasks
@turker0 turker0 mentioned this issue May 27, 2021
Closed
@kerm1it
Copy link
Contributor

kerm1it commented Jun 1, 2021

Can I take this issue?

@lunaleaps
Copy link
Contributor Author

@kerm1it assigned, thanks for working on this! Please set me as a reviewer for your pull request!

@kerm1it kerm1it mentioned this issue Jun 2, 2021
Closed
@kerm1it
Copy link
Contributor

kerm1it commented Jun 2, 2021

ref: #31644

I have no permission to set reviewer.

@lunaleaps
Copy link
Contributor Author

@kerm1it oh no! I didn't realize! Is there anyway for you to request a reviewer?

Setito pushed a commit to Setito/react-native that referenced this issue Jul 17, 2021
@kerm1it @Setito
remove defaultProps from picker of components (facebook#31644)
7c65cc0 
Summary:
Remove `defaultProps` from `Picker` of components, replace it with destructuring assignment.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[JavaScript] [Changed] - Remove defaultProps from picker

close facebook#31603

Pull Request resolved: facebook#31644

Test Plan: all test suite and CI passes.

Reviewed By: TheSavior

Differential Revision: D28886320

Pulled By: lunaleaps

fbshipit-source-id: d88a922dffeebe2bce019250d460b5e43a0af562
@facebook facebook locked as resolved and limited conversation to collaborators Jun 5, 2022
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kerm1it kerm1it

Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove defaultProps from picker of components
3 participants
@lunaleaps @react-native-bot @kerm1it