-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deeplinking is being interrupted by "Cannot read property 'apply' of undefined". #35577
Comments
Upgrading from 0.67 to 0.70.6 and meet exactly this problem |
I came to this, too. and I find the |
Same problem after update to 0.70.6 |
@olosegres @s123121 @taoqf |
I also have this issue with React native 0.69.7 |
No firebase usage within my project. |
Same problem after updating to 0.71.0 |
@seco35 - I investigated this and I believe a regression occurred in this commit - e5c5dcd old // The subscription may have been removed during this event loop.
if (subscription && subscription.listener) {
subscription.listener.apply(subscription.context, args);
} new if (registrations != null) {
for (const registration of [...registrations]) {
registration.listener.apply(registration.context, args);
}
} It seems a possibility that we could have a registration without listener. I'm guessing since this was changed in RN70 that it might be at least the original issue reported here. Thought the typing looks like this shouldn't be possible :/
@yungsters - Sorry for ping, but you authored the commit I linked and perhaps have an idea if I'm off base or not on this research. |
Thanks for the investigation @iBotPeaches hopefully they will merge it soon. |
hey guys! when is this correction expected to be published? |
This error is symptomatic of Can someone help me understand the source of the non-function value being supplied to the 2nd argument to cc @javache |
I was able to evaluate the problematic package in my case was: But the problem only happened in a specific scenario but I will do some further investigation once I find some time. **Turns out that only fixed the issue on IOS 🤔 man this is confusing |
This seems different from the original issue, which was causing a crash when events were emitted. Is it possible you have multiple copies of react-native in your application? |
This new problem is happening because I used this trick in the first comment:
But, in my case, I just used the ? before .apply
If I don't use this, the same thing described in the original issue happens to me.
I was able to make my app work properly by downgrading to version 0.69.8 (which is the last version that doesn't have this new EventEmitter) |
What happens if you change Do you get an error and more meaningful stack trace? |
@yungsters I put here, like this:
And also this:
in the emit function, like in my previous comment. These are the logs when I initialize the release version of the app:
It does not Throw, and the this._registry is without the correct Set(s) inside. Maybe is some config in the release mode that is wrong? It does not make sense to me |
I am also facing the same issue after upgrading from 066.4 to 0.70.6 reactnative |
hey guys! when is this correction expected to be published? |
This reverts commit 2a2c1f2.
@AlexandreMuskus I just updated the pr. But now it will not fix your issue it will only help you to find the problem. |
Hey, |
Hello, just curious if there is any update on this issue or not? I'm running into the exact same error as OP. |
React Native v0.72 will include 2780ba3, which changes This should help everyone here narrow down the originating source of this error in order to find out where the non-function is coming from (and where to fix the root cause). |
Hi! I encountered the same problem and made a slight adjustment to this line, which seemed a bit off. The spread operation appeared unnecessary:
To my surprise, this change fixed the issue cc @yungsters . The problem arose after upgrading from version 0.69 to 0.72. I have Hermes enabled. Here's a complete patch file for anyone else who might be grappling with this issue:
|
I had the same error, and I fixed it by doing this For me, the incorrect setup of I hope this helps some else out there Edit |
The spread is required to allow listeners to be added and removed during the execution of the event callback. |
So the idea is to make a copy of
updated patch:
It solves the issue, which seems to be caused by a bug in the JS engine/compiler/transpiler (?). Essentially, it incorrectly converts a
I cannot reproduce it on https://hermesengine.dev/playground/, so I presume it is caused by Babel. |
That's great! It would be good to understand which layer of the stack is causing this bug though. Polyfilling of Set/Map should no longer be required for RN builds, since modern JS engines support them natively. |
@mikollo — It seems like the spread operator ( Can you try verifying the following in your environment?
Are you able to reproduce this in a standard application setup? We can certainly (and probably should) replace |
Summary: Switches `EventEmitter#emit` to use `Array.from` instead of the spread operator. This should be functionally identical (with marginally less overhead of the runtime having to determine the type of `registrations`), but there seems to be [some unexpected Babel configurations in the community](facebook#35577 (comment)) that causes this line of code to do the wrong things. Although we should independently root cause the Babel plugin configuration problems, this change might provide immediate relief and is also not any worse (e.g. in terms of code readability). This also adds a descriptive comment explaining the intention of the call to `Array.from`. Changelog: [Fixed][General] - Fix a potential bug in `EventEmitter` when used with certain Babel configurations that incorrectly polyfill the spread operator for iterables. Differential Revision: D49389813
In the meantime, I've created #39525 to change |
I now see what was the root cause, I had the
and it transpiles I believe this is not a standard application setup ( |
Thanks for following up with that context, @mikollo! I am curious whether other folks who have encountered this issue (and commented above) also made use of the |
Summary: Switches `EventEmitter#emit` to use `Array.from` instead of the spread operator. This should be functionally identical (with marginally less overhead of the runtime having to determine the type of `registrations`), but there seems to be [some unexpected Babel configurations in the community](facebook#35577 (comment)) that causes this line of code to do the wrong things. Although we should independently root cause the Babel plugin configuration problems, this change might provide immediate relief and is also not any worse (e.g. in terms of code readability). This also adds a descriptive comment explaining the intention of the call to `Array.from`. Changelog: [Fixed][General] - Fix a potential bug in `EventEmitter` when used with certain Babel configurations that incorrectly polyfill the spread operator for iterables. Reviewed By: javache Differential Revision: D49389813
Summary: Pull Request resolved: #39525 Switches `EventEmitter#emit` to use `Array.from` instead of the spread operator. This should be functionally identical (with marginally less overhead of the runtime having to determine the type of `registrations`), but there seems to be [some unexpected Babel configurations in the community](#35577 (comment)) that causes this line of code to do the wrong things. Although we should independently root cause the Babel plugin configuration problems, this change might provide immediate relief and is also not any worse (e.g. in terms of code readability). This also adds a descriptive comment explaining the intention of the call to `Array.from`. Changelog: [Fixed][General] - Fix a potential bug in `EventEmitter` when used with certain Babel configurations that incorrectly polyfill the spread operator for iterables. Reviewed By: javache Differential Revision: D49389813 fbshipit-source-id: 7caf63734fc047496afe2f1ed6d918c22747258a
Summary: Pull Request resolved: facebook#39525 Switches `EventEmitter#emit` to use `Array.from` instead of the spread operator. This should be functionally identical (with marginally less overhead of the runtime having to determine the type of `registrations`), but there seems to be [some unexpected Babel configurations in the community](facebook#35577 (comment)) that causes this line of code to do the wrong things. Although we should independently root cause the Babel plugin configuration problems, this change might provide immediate relief and is also not any worse (e.g. in terms of code readability). This also adds a descriptive comment explaining the intention of the call to `Array.from`. Changelog: [Fixed][General] - Fix a potential bug in `EventEmitter` when used with certain Babel configurations that incorrectly polyfill the spread operator for iterables. Reviewed By: javache Differential Revision: D49389813 fbshipit-source-id: 7caf63734fc047496afe2f1ed6d918c22747258a
Summary: Pull Request resolved: #39525 Switches `EventEmitter#emit` to use `Array.from` instead of the spread operator. This should be functionally identical (with marginally less overhead of the runtime having to determine the type of `registrations`), but there seems to be [some unexpected Babel configurations in the community](#35577 (comment)) that causes this line of code to do the wrong things. Although we should independently root cause the Babel plugin configuration problems, this change might provide immediate relief and is also not any worse (e.g. in terms of code readability). This also adds a descriptive comment explaining the intention of the call to `Array.from`. Changelog: [Fixed][General] - Fix a potential bug in `EventEmitter` when used with certain Babel configurations that incorrectly polyfill the spread operator for iterables. Reviewed By: javache Differential Revision: D49389813 fbshipit-source-id: 7caf63734fc047496afe2f1ed6d918c22747258a
* Move hermes-engine.podspec and hermes-utils.rb from hermes-engine to hermes folders when building (facebook#39575) * Update Xcode 15 patches to be more robust (facebook#39710) Summary: Pull Request resolved: facebook#39710 Last week Apple released Xcode 15, which required us to ship a workaround for the new linker. Unfortunately, the previous fix was not good enough and there were some edge cases that were not covered. For example, in some occasions the flags are read as an array and the `-Wl` and the `-ld_classic` flags were separated and not properly removed when moving from Xcode 15 to Xcpde 14.3.1. This change fixes those edge cases, with a more robust solution where: - We convert the flags to a string. - We trim the string and the values properly. - We add the flags when running `pod install` with Xcode 15 as the default iOS toolchain. - We remove the flags when running `pod install` with Xcode <15 as the default iOS toolchain. ## Changelog: [Internal] - Make the Xcode 15 workaround more robust. Reviewed By: dmytrorykun Differential Revision: D49748844 fbshipit-source-id: 34976d148f123c5aacba6487a500874bb938fe99 # Conflicts: # packages/react-native/scripts/cocoapods/__tests__/utils-test.rb # packages/react-native/scripts/cocoapods/utils.rb * Fix Gemfile, setting Active support to < 7.1.0 (facebook#39828) Summary: Pull Request resolved: facebook#39828 Active Suppert released a new Gem which is incompatible with Cocoapods 1.13.0, the latest release, as they removed a method used by cocoapods. This fix ensures that we install compatible versions of the Gem. ## Changelog: [iOS][Fixed] - Set the max version of Active support to 7.0.8 Reviewed By: hoxyq Differential Revision: D49949782 fbshipit-source-id: 278097502d3a416567cc8c0b90090fee4fb21503 # Conflicts: # Gemfile * RN: Switch EventEmitter to `Array.from(...)` (facebook#39525) Summary: Pull Request resolved: facebook#39525 Switches `EventEmitter#emit` to use `Array.from` instead of the spread operator. This should be functionally identical (with marginally less overhead of the runtime having to determine the type of `registrations`), but there seems to be [some unexpected Babel configurations in the community](facebook#35577 (comment)) that causes this line of code to do the wrong things. Although we should independently root cause the Babel plugin configuration problems, this change might provide immediate relief and is also not any worse (e.g. in terms of code readability). This also adds a descriptive comment explaining the intention of the call to `Array.from`. Changelog: [Fixed][General] - Fix a potential bug in `EventEmitter` when used with certain Babel configurations that incorrectly polyfill the spread operator for iterables. Reviewed By: javache Differential Revision: D49389813 fbshipit-source-id: 7caf63734fc047496afe2f1ed6d918c22747258a * [Local] Fix CI for 0.72, with Acitve Support and Xcode15 (facebook#40855) * [0.72.6] Bump version numbers * Bump deprecated-react-native-prop-types to ^4.2.3 This version correctly sets a dependency on `"@react-native/normalize-colors": "<0.73.0"` (from `"*"`), preventing future unwanted breakages. * Fix broken Loading/Refreshing indicator on Android Summary: The Loading.../Refreshing... indicator is currently broken on Android. The reason is related to D42599220 We used to have a Toast shown to users on Android as a fallback, but as the DevLoadingView is not always loaded as a module in the core package, this ends up in the banner never beign shown to the user (on RN Tester or template apps). Changelog: [Android] [Fixed] - Fix broken Loading/Refreshing indicator on Android Reviewed By: cipolleschi Differential Revision: D49876757 fbshipit-source-id: 400e002327ebca908e3e7a7f81c5066888ac4e9b --------- Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com> Co-authored-by: Tim Yung <yungsters@meta.com> Co-authored-by: Distiller <distiller@static.38.39.185.90.cyberlynk.net> Co-authored-by: Alex Hunt <hello@alexhunt.io> Co-authored-by: Nicola Corti <ncor@meta.com>
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This issue was closed because it has been stalled for 7 days with no activity. |
Description
This error occured after upgrading to 0.7x from 0.67 and deeplink worked properly before doing the upgrade.
Have to mention that in both cases (background state & starting through deeplink) the url of the deeplink is there (looking with console.log()).
This error is being thrown only if the app is in background, starting the app through deeplink throws no error.
TypeError: Cannot read property 'apply' of undefined, js engine: hermes
While debugging on simulator, I could just minimize the thrown error and actions defined for the deeplink are processed properly. However the thrown error seems to block the execution of the deeplink actions on a real device.
The error is caused as shown in the thrown error at emit()-method of EventEmitter.js (Line 105):
Adding a check if the listener is undefined before execution solves the issue for me and deeplink works as expected (both on the simulator and the real device):
Unfortunately I am not sure, how this does effect the app in general and whether it must be solved by doing something else.
Version
0.70.4
Output of
npx react-native info
System:
OS: macOS 13.0
CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
Memory: 32.26 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.14.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 8.3.1 - /usr/local/bin/npm
Watchman: 2022.03.21.00 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
Android SDK:
API Levels: 30, 31, 32
Build Tools: 30.0.2, 30.0.3, 32.0.0, 32.1.0
System Images: android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom, android-31 | Google Play Intel x86 Atom_64
Android NDK: Not Found
IDEs:
Android Studio: 2021.2 AI-212.5712.43.2112.8609683
Xcode: 14.0.1/14A400 - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_322 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.4 => 0.70.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Create a project and configure deeplinking using the docs.
Add to AppDelegate.m:
in JSX:
Snack, code example, screenshot, or link to a repository
The text was updated successfully, but these errors were encountered: