Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiline TextInput's padding top style does not change when using padding or paddingVertical #41773

Closed
Spice-Z opened this issue Dec 3, 2023 · 1 comment

Comments

@Spice-Z
Copy link
Contributor

Spice-Z commented Dec 3, 2023

Description

As I said in title, multiline TextInput's padding top style does not change when using padding or paddingVertical .

I already made a PR.

#41772

React Native Version

0.72.7

Output of npx react-native info

System:
OS: macOS 14.1.1
CPU: (8) arm64 Apple M1
Memory: 81.31 MB / 16.00 GB
Shell:
version: 3.4.0
path: /opt/homebrew/bin/fish
Binaries:
Node:
version: 18.17.1
path: ~/.nodenv/versions/18.17.1/bin/node
Yarn:
version: 1.22.19
path: /opt/homebrew/bin/yarn
npm:
version: 9.6.7
path: ~/.nodenv/versions/18.17.1/bin/npm
Watchman:
version: 2023.08.14.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.14.3
path: /Users/main/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.0
- iOS 17.0
- macOS 14.0
- tvOS 17.0
- watchOS 10.0
Android SDK: Not Found
IDEs:
Android Studio: 2021.2 AI-212.5712.43.2112.8815526
Xcode:
version: 15.0.1/15A507
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.17
path: /usr/bin/javac
Ruby:
version: 3.2.2
path: /Users/main/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.7
wanted: 0.72.7
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: Not found
newArchEnabled: Not found
iOS:
hermesEnabled: Not found
newArchEnabled: Not found

Steps to reproduce

  • Use TextInput with multiline={true}
  • Set paddingVertical or padding style to TextInput
  • Top padding is always 5 !

You can easily reproduce like this code

<TextInput multiline={true} style={{paddingVertical:0}} />

Snack, screenshot, or link to a repository

https://snack.expo.dev/@spice-x/honest-blue-chocolates

Copy link

github-actions bot commented Dec 3, 2023

⚠️ Newer Version of React Native is Available!
ℹ️ You are on a supported minor version, but it looks like there's a newer patch available - 0.72.7. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

@github-actions github-actions bot added Newer Patch Available Component: TextInput Related to the TextInput component. labels Dec 3, 2023
Othinn pushed a commit to Othinn/react-native that referenced this issue Jan 9, 2024
Summary:
Fixed: facebook#41773

## Changelog:

[GENERAL] [FIXED] - not applying `multilineInput` when props's style has paddingTop related style

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[GENERAL] [FIXED] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests

Pull Request resolved: facebook#41772

Reviewed By: NickGerleman

Differential Revision: D51894473

Pulled By: yungsters

fbshipit-source-id: f11466100111cd8dd5f36bdbd4eb99f6a1633d66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant