[react-native-cli] fixed issue with runIOS not being able to launch tvOS app

[joeyjiron06]

Is this a bug report?

Yes.

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: MacOS X 10.12.6 (16G29)
Node: 8.9.4
Yarn: N/A
npm: 5.4.2
Watchman: Not Found
Xcode: 9.2 (9C40b)
Android Studio: N/A

Bug Summary

[CLI iOS runIOS] When using react-native-cli to try to launch the tvOS scheme the user get's an error because the current implementation for launching simulators ignores any simulator/device who's name does not start with iOS

Steps to Reproduce

StackOverflow issue also found here : https://stackoverflow.com/questions/48069690/how-to-select-project-to-run-tvos-version-with-npm-start

Actual command line steps

$npm i -g react-native-cli
...
$react-native init CoolProject
...
$cd CoolProject/
$react-native run-ios --simulator "Apple TV"  --scheme "CoolProject-tvOS"

Scanning folders for symlinks in /Users/jjiron/CoolProject/node_modules (7ms)
Found Xcode project CoolProject.xcodeproj
CoreData: annotation:  Failed to load optimized model at path '/Applications/Xcode.app/Contents/Applications/Instruments.app/Contents/Frameworks/InstrumentsPackaging.framework/Versions/A/Resources/XRPackageModel.momd/XRPackageModel 9.0.omo'

Could not find Apple TV simulator

Expected Behavior

The cli tool should launch the tvOS application on the simulator.

Actual Behavior

The user get's an error message saying "Could not find Apple TV simulator"

The Fix

Don't ignore appletv simulators when looking for simulators to launch. Also use the correct application build when selecting which app to launch on the simulator/device.

Test Plan

Added automated test for findMatchingSimulator.js to allow tvOS simulators

Release Notes

[react-native-cli] Fixed issue where you cannot launch tvOS app on Apple TV simulator

[pull-bot]

	Warnings
⚠️	📋 Release Notes - This PR may have incorrectly formatted Release Notes.

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

[facebook-github-bot]

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[joeyjiron06]

yes this merges cleanly onto the master branch. im guessing that the merge doesnt work because ci/circleci: build/hold is on hold, and ci/circleci: analyze-pull-request failed. looking at the logs it seems like the npm install failed...not sure why, but i know it can happen from time to time on a CI server.

can someone re-run those jobs and try merging again? (i don't have permissions to run those jobs)

[hramos]

A rebase is needed due to some changes that happened earlier this week in our internal monorepo outside of the synced react-native directory (but nonetheless prevent this PR from landing). Simply hitting Update branch should resolve it, let's see.

[facebook-github-bot]

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[joeyjiron06]

any update on this @hramos ?

[joeyjiron06]

why did the bot close this issue?

[hramos]

The bot closes pull requests automatically after merging them.