Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textTransform inheritance on Android #22694

Closed
wants to merge 2 commits into from

Conversation

janicduplessis
Copy link
Contributor

The textTransform inheritance is currently broken on Android because we don't map constants properly in setTextTransform. null should map to TextTransform.UNSET.

<Text style={{textTransform: 'uppercase'}}>
  <Text style={{textTransform: 'none'}}>a</Text>
  <Text style={{textTransform: null}}>b</Text>
</Text>

This should render aB but renders ab on android before this fix.

Thanks @rigdern for pointing this out!

Changelog:

[Android] [Fixed] - Fix textTransform inheritance on Android

Test Plan:

Using the example above I reproduced the bug and made sure it renders the proper value after the fix.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2018
…BaseTextShadowNode.java

Co-Authored-By: janicduplessis <janicduplessis@gmail.com>
@janicduplessis
Copy link
Contributor Author

Included this change in #22670 as I ended up changing this code.

@zpao zpao deleted the janicduplessis-patch-10 branch January 31, 2019 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: Text Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants