Consistent reporting native module name on crash on native side #24741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cpojer
approved these changes
May 7, 2019
facebook-github-bot
approved these changes
May 7, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
react-native-bot
added
the
Type: Enhancement
No problem, it happens! ;) Thank you for developing such a great framework. |
|
This pull request was successfully merged by @DimitryDushkin in b79d7db. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reopened PR #24704 (comment)
PR #24633 introduced some inconsistency in crash messaging, this PR fix it. Asked by @mhorowitz
Changelog
[General] [Added] - Consistent reporting native module name on crash on native side
Test Plan
Actually I didn't managed to reproduce this kind of crash, looks like something changed here.