bump @typescript-eslint and prettier versions in eslint-config #27319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@matthargett @michalchudziak please publish updated package to npm. Thanks |
|
For this to be merged we have to upgrade these packages across the rest of the Facebook monorepo. It might be a little while for someone to get to this. |
benoitdion
reviewed
Nov 27, 2019
| "eslint-plugin-react": "7.16.0", | ||
| "eslint-plugin-react-hooks": "^2.0.1", | ||
| "eslint-plugin-react-native": "3.8.1", | ||
| "prettier": "1.17.0" | ||
| "prettier": "^1.17.0" |
There was a problem hiding this comment.
do you think this could be bumped to 1.19.1 for typescript optional chaining support?
There was a problem hiding this comment.
is there any idea to use typescript optional chaining in react native? Sorry to beginner question
|
@hramos might be able to help with updating these packages |
|
Seems like this can be closed as #28393 solved the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds eslint 6 support to @react-native-community/eslint-config by bumping old dependencies and changing eslint version requirements.
Changelog
[General] [Changed] - add ESLint 6 support to @react-native-community/eslint-config
Test Plan
Below warnings are gone