Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DevSettings to jest preset #29223

Closed
wants to merge 2 commits into from
Closed

Add DevSettings to jest preset #29223

wants to merge 2 commits into from

Conversation

MarcoScabbiolo
Copy link
Contributor

@MarcoScabbiolo MarcoScabbiolo commented Jun 25, 2020 •
edited
Loading

Summary

Provide a mocked DevSettings implementation for jest.

Changelog

[General] [Added] - Add mock for DevSettings to jest preset

Test Plan

None

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Jun 25, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,761,578 0
android hermes armeabi-v7a 6,424,796 0
android hermes x86 7,148,717 0
android hermes x86_64 7,038,696 0
android jsc arm64-v8a 8,934,968 0
android jsc armeabi-v7a 8,590,566 0
android jsc x86 8,765,230 0
android jsc x86_64 9,340,847 0

Base commit: 530d11c

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 530d11c

facebook-github-bot
facebook-github-bot reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @MarcoScabbiolo in a50f736.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcoScabbiolo @analysis-bot @react-native-bot @facebook-github-bot