Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove PushNotificationIOS following the issue Lean Core #23313 #30026

Closed

Conversation

cromatikap
Copy link

Summary

Remove the deprecated PushNotificationIOS and its references, following the issue Lean Core #23313

Changelog

[iOS] [removed] - PushNotificationIOS removed

Test Plan

PushNotificationIOS is deprecated. Use @react-native-community/push-notification-ios instead.

@facebook-github-bot
Copy link
Contributor

Hi @bidetaggle!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added p: Expo Partner: Expo Partner CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 24, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@analysis-bot
Copy link

analysis-bot commented Sep 24, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,369,209 -2,164
android hermes armeabi-v7a 6,996,273 -2,180
android hermes x86 7,809,709 -2,164
android hermes x86_64 7,701,259 -2,176
android jsc arm64-v8a 9,515,282 -1,052
android jsc armeabi-v7a 9,134,498 -1,044
android jsc x86 9,381,366 -1,040
android jsc x86_64 9,962,284 -1,044

Base commit: 0a0d2c9

@gedeagas
Copy link
Contributor

gedeagas commented Sep 24, 2020

Nice.
As far as I know, PushNotificationIOS is still used internally at FB, and finally, someone refactors it :D

@Simek
Copy link
Collaborator

Simek commented Sep 26, 2020

Nice.
As far as I know, PushNotificationIOS is used internally at FB, and finally, someone refactors it :D

react-native-community/releases#207 (comment)

@gedeagas
Copy link
Contributor

Nice.

As far as I know, PushNotificationIOS is used internally at FB, and finally, someone refactors it :D

react-native-community/releases#207 (comment)

So it's still used internally then 😞

@Simek
Copy link
Collaborator

Simek commented Sep 26, 2020

@bidetaggle You have missed import and handlers in RNTester app:

@analysis-bot
Copy link

analysis-bot commented Sep 26, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0a0d2c9

@github-actions
Copy link

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants