Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] [Changed] Pass reactNativePath to codegen_pre_install #30448

Closed
wants to merge 1 commit into from

Conversation

brunolemos
Copy link
Contributor

Summary

codegen_pre_install needs the path param as much as use_react_native, and we pass to use_react_native by default.

use_react_native!(:path => config[:reactNativePath])

pre_install do |installer|
codegen_pre_install(installer)
end

Changelog

[iOS] [Changed] - Pass reactNativePath to codegen_pre_install

Test Plan

Tested on my local machine, pod install fails if I set reactNativePath to an wrong path and works if it's correct:

image

ping: react-native-community/releases#207

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2020
@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Nov 21, 2020
@brunolemos brunolemos changed the title [iOS] [Changed] Pass reactNativePath to codegen_pre_install like we do with use_react_native [iOS] [Changed] Pass reactNativePath to codegen_pre_install Nov 21, 2020
@brunolemos
Copy link
Contributor Author

Closing since codegen invocation was moved out of the podfile c901c1f#diff-fcc02228077c73cb58800911f68c7de9938b9848279ee6caa73c27dd63d27212

@brunolemos brunolemos closed this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants