Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ImageBackgroundPropType #32099

Closed

Conversation

Naturalclar
Copy link
Contributor

Summary

Added FlowType definition for ImageBackground component Props

Changelog

[General] [Changed] - Add ImageBackground component type definition

Test Plan

  • flow check passes
  • rn-tester app runs

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2021
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues. Run yarn lint --fix to automatically fix problems.

@yungsters
Copy link
Contributor

Very nice! Thank you.

@facebook-github-bot
Copy link
Contributor

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ca60be8

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,246,715 -13
android hermes armeabi-v7a 8,765,376 -20
android hermes x86 9,689,346 -20
android hermes x86_64 9,657,021 -11
android jsc arm64-v8a 10,883,359 +13
android jsc armeabi-v7a 9,793,291 +14
android jsc x86 10,921,394 +9
android jsc x86_64 11,530,578 +20

Base commit: ca60be8

@facebook-github-bot
Copy link
Contributor

@yungsters merged this pull request in dbd5c3d.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants