Remove iOS 11 version check #32151
Closed
Remove iOS 11 version check #32151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ken0nek! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: 8e66f0b |
Base commit: 8e66f0b |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
KukretiShubham
approved these changes
Sep 7, 2021
yungsters
added
the
Shared with Meta
|
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@yungsters merged this pull request in 398595e. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2021
Summary:
This pull request aims to remove iOS 11 availability check which is no longer needed.
The minimum iOS deployment target for React Native is iOS 11 but we still have iOS 11 version check like below.
```
if (available(iOS 11.0, *)) {
```
This is a continuation pull request of #32151
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
[iOS] [Changed] - Remove iOS 11 availability check
Pull Request resolved: #32488
Reviewed By: yungsters
Differential Revision: D32006312
Pulled By: ryancat
fbshipit-source-id: 0ee6579e433a15d3d220a52d2ccd6931b0513971
facebook-github-bot
pushed a commit
that referenced
this pull request
May 16, 2022
Summary: We don't have to check or emulate the safe area for iOS 11 above. I deleted the unnecessary check for the safe area. This is a continuation pull request of these iOS 11 availability check. * [Remove iOS 11 version check by ken0nek · Pull Request #32151 · facebook/react-native](#32151) * [Remove iOS 11 availability check by ken0nek · Pull Request #32488 · facebook/react-native](#32488) ----- - Stop using layout guide (`topLayoutGuide`, `bottomLayoutGuide`) - Refactor `RCTSafeAreaView` - Delete `emulateUnlessSupported` property Docs PR: facebook/react-native-website#2919 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Removed] - Remove `emulateUnlessSupported` Pull Request resolved: #32851 Reviewed By: philIip, sammy-SC Differential Revision: D33586023 Pulled By: cortinico fbshipit-source-id: 75fc1037141f71d9340c7b875a6bf86f9cfd6a02
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
Summary: I removed the code checking iOS 12 availability because the iOS minimum deployment target is now iOS 12.4 after these commits (982ca30, c71e6ef). My previous pull requests regarding iOS 11 * [Remove iOS 11 version check by ken0nek · Pull Request #32151 · facebook/react-native](#32151) * [Remove iOS 11 availability check by ken0nek · Pull Request #32488 · facebook/react-native](#32488) * [Remove iOS 11 deprecation warnings around SafeArea by ken0nek · Pull Request #32851 · facebook/react-native](#32851) ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Changed] - Remove iOS 12 availability check Pull Request resolved: #33460 Reviewed By: NickGerleman Differential Revision: D35021632 Pulled By: javache fbshipit-source-id: bf85d44874a2c10cb345d33df7c9e4789312a7cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request aims to remove iOS 11 version check which is no longer needed.
The minimum iOS deployment target for React Native is
iOS 11but we still have iOS 11 version check like below.ref: https://github.com/facebook/react-native#-requirements
If there is a team motivation to remove the deprecated methods and classes before iOS 10, I can continue the work in this pull request or in the continuing pull requests.
We have deprecated warnings for these in the project.
UIUserNotificationSettingsUILocalNotificationtopLayoutGuideandbottomLayoutGuideautomaticallyAdjustsScrollViewInsetsChangelog
[iOS] [Changed] - Remove iOS 11 version check
Test Plan