Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: find-node.sh location in react-native-xcode.sh script #32227

Closed
wants to merge 1 commit into from
Closed

Fix: find-node.sh location in react-native-xcode.sh script #32227

wants to merge 1 commit into from

Conversation

garethknowles
Copy link
Contributor

Summary

Fix the find-node.sh call in react-native-xcode.sh script

Related issue

#32168

Changelog

[iOS] [Fixed] - Fix for unable to find find-node.sh in react-native-xcode.sh script

Test Plan

• Run an Xcode build which uses the scripts/react-native-xcode.sh in the JS Bundle build phase.

@facebook-github-bot
Copy link
Contributor

Hi @garethknowles!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@garethknowles garethknowles changed the title Replaced RN_DIR with REACT_NATIVE_DIR Fix: find-node.sh in react-native-xcode.sh script Sep 17, 2021
@garethknowles garethknowles changed the title Fix: find-node.sh in react-native-xcode.sh script Fix: find-node.sh location in react-native-xcode.sh script Sep 17, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5683932

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,705,285 +0
android hermes armeabi-v7a 7,236,467 +0
android hermes x86 8,126,260 +0
android hermes x86_64 8,091,221 +0
android jsc arm64-v8a 9,625,139 +0
android jsc armeabi-v7a 8,543,852 +0
android jsc x86 9,640,401 +0
android jsc x86_64 10,249,056 +0

Base commit: 5683932

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 17, 2021
@facebook-github-bot
Copy link
Contributor

@GijsWeterings has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@GijsWeterings merged this pull request in cc59a7c.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 17, 2021
@garethknowles garethknowles deleted the patch-1 branch September 20, 2021 07:56
lunaleaps pushed a commit that referenced this pull request Oct 15, 2021
@garethknowles
Fix: find-node.sh location in react-native-xcode.sh script (#32227)
bd01f16 
Summary:
Fix the `find-node.sh` call in `react-native-xcode.sh` script

## Related issue
#32168

## Changelog

[iOS] [Fixed] - Fix for unable to find `find-node.sh` in `react-native-xcode.sh` script

Pull Request resolved: #32227

Test Plan: • Run an Xcode build which uses the `scripts/react-native-xcode.sh` in the JS Bundle build phase.

Reviewed By: TheSavior

Differential Revision: D31022043

Pulled By: GijsWeterings

fbshipit-source-id: 10aafd595c3a3a87c22f385ca4f61756f67e9b9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garethknowles @facebook-github-bot @analysis-bot