Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider relative to pwd installation root when looking for files in rn module via cocoapods #33399

Closed
wants to merge 1 commit into from
Closed

Consider relative to pwd installation root when looking for files in rn module via cocoapods #33399

wants to merge 1 commit into from

Commits on Mar 9, 2022

  1. Consider relative to pwd installation root when looking for files in … 

    …rn module via cocoapods

The :reactNativePath provided by use_native_modules! is the rn module path relative to the installation root (usually ./ios). However, when executing cocoapods from a dir thats not the installation root, packages that use the relative :reactNativePath variable in their path must also consider the relative to pwd installation root.

This fixes usage of cocoapods with the --project-directory flag like

bundle exec pod install --project-directory=ios
    @danilobuerger
    danilobuerger committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    139bbd3 View commit details
    Browse the repository at this point in the history