Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass node executable to codegen #33672

Closed
wants to merge 1 commit into from
Closed

Pass node executable to codegen #33672

wants to merge 1 commit into from

Commits on Apr 20, 2022

  1. Pass node executable to codegen 

    Summary:
This pr adds a parameter to the `create-artifacts.js` script to accept the path to a node executable, falling back to `node` in case the parameter has not been passed.
Then, it passes the NODE_BINARY to the script in the `script_phases.sh` script.

This PR decouples the `node` environment from the system one and fixes a build issue in the new architecture when the environment has no `node`

## Changelog

[iOS][Changed] - Update CodeGen scripts to accept custom node executable

Differential Revision: D35748497

fbshipit-source-id: a93d6765f40975f6c7a0739be303470d885a3a58
    @facebook-github-bot
    Riccardo Cipolleschi authored and facebook-github-bot committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    549e160 View commit details
    Browse the repository at this point in the history