fix(jest): make assetFileTransformer return an object #33756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
geraintwhite
changed the title
|
Please address the CI failures first |
geraintwhite
force-pushed
the
patch-6
branch
2 times, most recently
from
5a66e3c
to
7cf785f
Compare
|
@cortinico apologies, my fault for making changes directly in GitHub! I think the Android build failures are unrelated. |
Base commit: d881c87 |
Yes we're about to land a fix for them. Let's hold on a bit. |
Base commit: d881c87 |
|
Looks like iOS is still failing for an unrelated reason |
Closed
Could you rebase again @grit96? The CI should be green, and we should be good merging this afterwards |
|
@cortinico all looks good now |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @grit96 in b5ff26b. When will my fix make it into a release? | Upcoming Releases |
1 task
kelset
pushed a commit
that referenced
this pull request
Jul 12, 2022
Summary: Fixes #33751 Relates to #33576 Jest 28 removed support for returning a string in the process method of a transformer (https://jestjs.io/docs/upgrading-to-jest28#transformer). This PR changes assetFileTransformer to return an object instead of a string. ## Changelog [Internal] [Fixed] - Return object from assetFileTransformer Pull Request resolved: #33756 Test Plan: Tests pass with Jest 28 when this change is made. Reviewed By: cipolleschi Differential Revision: D37242038 Pulled By: cortinico fbshipit-source-id: d8a5054f5378183f644cd1458785084b26782193
danilobuerger
pushed a commit
to feastr/react-native
that referenced
this pull request
Jul 25, 2022
Summary: Fixes facebook#33751 Relates to facebook#33576 Jest 28 removed support for returning a string in the process method of a transformer (https://jestjs.io/docs/upgrading-to-jest28#transformer). This PR changes assetFileTransformer to return an object instead of a string. ## Changelog [Internal] [Fixed] - Return object from assetFileTransformer Pull Request resolved: facebook#33756 Test Plan: Tests pass with Jest 28 when this change is made. Reviewed By: cipolleschi Differential Revision: D37242038 Pulled By: cortinico fbshipit-source-id: d8a5054f5378183f644cd1458785084b26782193
danilobuerger
pushed a commit
to feastr/react-native
that referenced
this pull request
Aug 10, 2022
Summary: Fixes facebook#33751 Relates to facebook#33576 Jest 28 removed support for returning a string in the process method of a transformer (https://jestjs.io/docs/upgrading-to-jest28#transformer). This PR changes assetFileTransformer to return an object instead of a string. ## Changelog [Internal] [Fixed] - Return object from assetFileTransformer Pull Request resolved: facebook#33756 Test Plan: Tests pass with Jest 28 when this change is made. Reviewed By: cipolleschi Differential Revision: D37242038 Pulled By: cortinico fbshipit-source-id: d8a5054f5378183f644cd1458785084b26782193
danilobuerger
pushed a commit
to feastr/react-native
that referenced
this pull request
Nov 18, 2022
Summary: Fixes facebook#33751 Relates to facebook#33576 Jest 28 removed support for returning a string in the process method of a transformer (https://jestjs.io/docs/upgrading-to-jest28#transformer). This PR changes assetFileTransformer to return an object instead of a string. ## Changelog [Internal] [Fixed] - Return object from assetFileTransformer Pull Request resolved: facebook#33756 Test Plan: Tests pass with Jest 28 when this change is made. Reviewed By: cipolleschi Differential Revision: D37242038 Pulled By: cortinico fbshipit-source-id: d8a5054f5378183f644cd1458785084b26782193
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33751
Relates to #33576
Summary
Jest 28 removed support for returning a string in the process method of a transformer (https://jestjs.io/docs/upgrading-to-jest28#transformer).
This PR changes assetFileTransformer to return an object instead of a string.
Changelog
[Internal] [Fixed] - Return object from assetFileTransformer
Test Plan
Tests pass with Jest 28 when this change is made.