Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use-subscripton with use-sync-external-store #33770

Closed
wants to merge 1 commit into from

Conversation

rickhanlonii
Copy link
Member

Summary:
React has replaced use-subscription with the React 18 compatible use-sync-external-store.

Changelog:
[General][Changed] - Replace use-subscripton with use-sync-external-store

Reviewed By: ryancat

Differential Revision: D35592432

Summary:
React has replaced use-subscription with the React 18 compatible use-sync-external-store.

Changelog:
[General][Changed] - Replace use-subscripton with use-sync-external-store

Reviewed By: ryancat

Differential Revision: D35592432

fbshipit-source-id: 03c65a2781f4549ca60a226691f18d9332e6c611
@rickhanlonii rickhanlonii requested a review from hramos as a code owner May 5, 2022 22:31
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels May 5, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D35592432

@pull-bot
Copy link

pull-bot commented May 5, 2022

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against c03759a

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,778,243 -607
android hermes armeabi-v7a 7,183,314 -608
android hermes x86 8,087,150 -603
android hermes x86_64 8,067,859 -605
android jsc arm64-v8a 9,652,990 -354
android jsc armeabi-v7a 8,426,761 -358
android jsc x86 9,602,610 -357
android jsc x86_64 10,200,262 -360

Base commit: 870755f
Branch: main

@ecreeth
Copy link
Contributor

ecreeth commented May 5, 2022

Why are we not using useSyncExternalStore directly from react? The template requires react@18

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: e5469c4
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @rickhanlonii in 93b50be.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 6, 2022
@cortinico
Copy link
Contributor

@fortmarek this is also something worth picking in .69 for the sake of React 18

@rickhanlonii rickhanlonii deleted the export-D35592432 branch May 9, 2022 14:10
fortmarek pushed a commit that referenced this pull request May 11, 2022
Summary:
Pull Request resolved: #33770

React has replaced use-subscription with the React 18 compatible use-sync-external-store.

Changelog:
[General][Changed] - Replace use-subscripton with use-sync-external-store

Reviewed By: ryancat

Differential Revision: D35592432

fbshipit-source-id: cc2016f66940e53f3614e110bafb02240bae1ae4
@tom-sherman
Copy link

@ecreeth React Native isn't dropping support for React 17 and below so needs to use the shim for apps on those versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants