-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use-subscripton with use-sync-external-store #33770
Conversation
Summary: React has replaced use-subscription with the React 18 compatible use-sync-external-store. Changelog: [General][Changed] - Replace use-subscripton with use-sync-external-store Reviewed By: ryancat Differential Revision: D35592432 fbshipit-source-id: 03c65a2781f4549ca60a226691f18d9332e6c611
This pull request was exported from Phabricator. Differential Revision: D35592432 |
Base commit: 870755f |
Why are we not using |
Base commit: e5469c4 |
This pull request was successfully merged by @rickhanlonii in 93b50be. When will my fix make it into a release? | Upcoming Releases |
@fortmarek this is also something worth picking in .69 for the sake of React 18 |
Summary: Pull Request resolved: #33770 React has replaced use-subscription with the React 18 compatible use-sync-external-store. Changelog: [General][Changed] - Replace use-subscripton with use-sync-external-store Reviewed By: ryancat Differential Revision: D35592432 fbshipit-source-id: cc2016f66940e53f3614e110bafb02240bae1ae4
@ecreeth React Native isn't dropping support for React 17 and below so needs to use the shim for apps on those versions |
Summary:
React has replaced use-subscription with the React 18 compatible use-sync-external-store.
Changelog:
[General][Changed] - Replace use-subscripton with use-sync-external-store
Reviewed By: ryancat
Differential Revision: D35592432