Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run script phases tests in CI and Sandcastle #33802

Closed
wants to merge 1 commit into from
Closed

Run script phases tests in CI and Sandcastle #33802

wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
We use to have a couple of tests for the script phases script that were not running during the CI.

This diff connect them with the two CI, so that they run together with the other ruby tests.

Changelog

[iOS][Added] - Run script phases tests in CI

Differential Revision: D36283211

@facebook-github-bot
Run script phases tests in CI and Sandcastle
ea77efa 
Summary:
We use to have a couple of tests for the script phases script that were not running during the CI.

This diff connect them with the two CI, so that they run together with the other ruby tests.

## Changelog
[iOS][Added] - Run script phases tests in CI

Differential Revision: D36283211

fbshipit-source-id: 70a26b8c74061f3e2143f2b08fa3f0cb9cce2a33
@cipolleschi cipolleschi requested a review from hramos as a code owner May 10, 2022 15:40
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 10, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36283211

@react-native-bot react-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels May 10, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,796,716 +0
android hermes armeabi-v7a 7,199,851 +0
android hermes x86 8,107,610 +0
android hermes x86_64 8,087,219 +0
android jsc arm64-v8a 9,669,313 +0
android jsc armeabi-v7a 8,441,221 +0
android jsc x86 9,620,830 +0
android jsc x86_64 10,217,602 +0

Base commit: 2e720c3
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 2e720c3
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in c171a6e.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cipolleschi @facebook-github-bot @analysis-bot @react-native-bot