Fix a bug for which is impossible to disable Hermes #34142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `||=` operator in an expression like `x = a ||= b` works in a way that: - if a is null, it assigns b to x - if a is `falsy`, it assigns b to x - otherwise, it assigns a to x. In our setup, if the user set `hermes_enabled` to `false` in the Podfile (one of the suggested way to disabled Hermes), the `options[:hermes_enabled]` part will evaluate to false and, therefore, `hermes_enabled` will obtain the value of `true`. ## Changelog [iOS][Changed] - Use the correct operator to decide whether Hermes is enabled or not. Differential Revision: D37643845 fbshipit-source-id: 0a1705ef107d45b4039cf50049f573823186d953
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37643845 |
Base commit: 303aaf8 |
Base commit: 303aaf8 |
|
This pull request was successfully merged by @cipolleschi in 6148844. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
||=operator in an expression likex = a ||= bworks in a way that:falsy, it assigns b to xIn our setup, if the user set
hermes_enabledtofalsein the Podfile (one of the suggested way to disabled Hermes), theoptions[:hermes_enabled]part will evaluate to false and, therefore,hermes_enabledwill obtain the value oftrue.Changelog
[iOS][Changed] - Use the correct operator to decide whether Hermes is enabled or not.
Differential Revision: D37643845